r105968 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105967‎ | r105968 | r105969 >
Date:01:52, 13 December 2011
Author:rsterbin
Status:ok
Tags:
Comment:
Fix variable temp leaking into the global scope (fixes r105750)
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
@@ -2449,7 +2449,7 @@
24502450 if ( !( requested in $.articleFeedbackv5.ctas ) ) {
24512451 requested = '0';
24522452 }
2453 - temp = $.articleFeedbackv5.ctas[requested];
 2453+ var temp = $.articleFeedbackv5.ctas[requested];
24542454 if ( 'verify' in temp ) {
24552455 if ( !temp.verify() ) {
24562456 requested = requested == '1' ? '2' : '0';

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r105750Updated the jquery module to override the edit CTA if the article is not...rsterbin03:29, 10 December 2011

Status & tagging log