r105920 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105919‎ | r105920 | r105921 >
Date:19:20, 12 December 2011
Author:jeroendedauw
Status:deferred
Tags:educationprogram 
Comment:
minor fixes
Modified paths:
  • /trunk/extensions/EducationProgram/includes/EPCoursePager.php (modified) (history)
  • /trunk/extensions/EducationProgram/includes/EPOrgPager.php (modified) (history)
  • /trunk/extensions/EducationProgram/includes/EPPager.php (modified) (history)
  • /trunk/extensions/EducationProgram/includes/EPStudentPager.php (modified) (history)

Diff [purge]

Index: trunk/extensions/EducationProgram/includes/EPStudentPager.php
@@ -18,7 +18,7 @@
1919 *
2020 * @param array $conds
2121 */
22 - public function __construct( array $conds ) {
 22+ public function __construct( array $conds = array() ) {
2323 $this->mDefaultDirection = true;
2424
2525 // when MW 1.19 becomes min, we want to pass an IContextSource $context here.
Index: trunk/extensions/EducationProgram/includes/EPOrgPager.php
@@ -18,7 +18,7 @@
1919 *
2020 * @param array $conds
2121 */
22 - public function __construct( array $conds ) {
 22+ public function __construct( array $conds = array() ) {
2323 $this->mDefaultDirection = true;
2424
2525 // when MW 1.19 becomes min, we want to pass an IContextSource $context here.
Index: trunk/extensions/EducationProgram/includes/EPPager.php
@@ -103,7 +103,7 @@
104104 $c = $this->className; // Yeah, this is needed in PHP 5.3 >_>
105105 return array(
106106 'tables' => array( $c::getDBTable() ),
107 - 'fields' => $c::getFieldNames(),
 107+ 'fields' => $c::getPrefixedFields( $c::getFieldNames() ),
108108 'conds' => $c::getPrefixedValues( $this->conds ),
109109 );
110110 }
@@ -168,7 +168,7 @@
169169 *
170170 * @return string
171171 */
172 - protected function getFilterControl( $hideWhenNoResults ) {
 172+ public function getFilterControl( $hideWhenNoResults ) {
173173 $filterOptions = $this->getFilterOptions();
174174
175175 if ( count( $filterOptions ) < 1 ) {
Index: trunk/extensions/EducationProgram/includes/EPCoursePager.php
@@ -18,7 +18,7 @@
1919 *
2020 * @param array $conds
2121 */
22 - public function __construct( array $conds ) {
 22+ public function __construct( array $conds = array() ) {
2323 $this->mDefaultDirection = true;
2424
2525 // when MW 1.19 becomes min, we want to pass an IContextSource $context here.

Status & tagging log