r105903 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105902‎ | r105903 | r105904 >
Date:17:15, 12 December 2011
Author:catrope
Status:ok
Tags:
Comment:
Fix indentation, comment typos and variable leakage in r105574
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.startup.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.startup.js
@@ -46,11 +46,11 @@
4747 'current': mw.config.get( 'wgCategories', [] )
4848 };
4949
50 - // Categories are configured with underscores, but article's categories are returned with
51 - // spaces instead. Revert to underscores here for sane comparison.
52 - for( cat in categories['current'] ) {
53 - categories['current'][cat] = categories['current'][cat].replace(/\s/gi, '_');
54 - }
 50+ // Categories are configured with underscores, but article's categories are returned with
 51+ // spaces instead. Convert to underscores here for sane comparison.
 52+ for ( var cat in categories['current'] ) {
 53+ categories['current'][cat] = categories['current'][cat].replace(/\s/gi, '_');
 54+ }
5555
5656 // Category exclusion
5757 var disable = false;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r105574AFTv5: Partial fix for #32842, fix categories for sample (underscore vs space)yonishostak19:16, 8 December 2011

Status & tagging log