r105900 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105899‎ | r105900 | r105901 >
Date:16:31, 12 December 2011
Author:santhosh
Status:ok
Tags:
Comment:
Correct the usage of mw.message with mw.msg, Follow up r105869
And some whitespace fixes.
Modified paths:
  • /trunk/extensions/WebFonts/resources/ext.webfonts.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WebFonts/resources/ext.webfonts.js
@@ -329,7 +329,7 @@
330330 .append( $menuItemsDiv );
331331 var $link = $( '<a>' )
332332 .prop( 'href', '#' )
333 - .text( mw.message( 'webfonts-load' ).escaped() )
 333+ .text( mw.msg( 'webfonts-load' ) )
334334 .attr( 'title', mw.msg( 'webfonts-menu-tooltip' ) );
335335 // This is the fonts link
336336 var $li = $( '<li>' ).attr( 'id', 'pt-webfont' ).append( $link );
@@ -339,7 +339,7 @@
340340 $( 'body' ).prepend( $menu );
341341 $li.click( function( event ) {
342342 $menuItemsDiv.css( 'left', $li.offset().left );
343 - if($menu.hasClass( 'open' ) ){
 343+ if( $menu.hasClass( 'open' ) ){
344344 $menu.removeClass( 'open' );
345345 } else{
346346 $( 'div.open' ).removeClass( 'open' );
@@ -349,7 +349,7 @@
350350 } );
351351 $( 'html' ).click( function() {
352352 $menu.removeClass( 'open' );
353 - });
 353+ } );
354354 // Workaround for IE bug - ActiveX components like input fields coming on top of everything.
355355 // @todo Is there a better solution other than hiding it on hover?
356356 if ( $.browser.msie ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r105869Add a tooltip text for the webfonts menu.santhosh12:08, 12 December 2011

Status & tagging log