r105869 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105868‎ | r105869 | r105870 >
Date:12:08, 12 December 2011
Author:santhosh
Status:resolved (Comments)
Tags:
Comment:
Add a tooltip text for the webfonts menu.
Modified paths:
  • /trunk/extensions/WebFonts/WebFonts.i18n.php (modified) (history)
  • /trunk/extensions/WebFonts/WebFonts.php (modified) (history)
  • /trunk/extensions/WebFonts/resources/ext.webfonts.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WebFonts/resources/ext.webfonts.js
@@ -327,7 +327,10 @@
328328 .attr( 'id', 'webfonts-menu' )
329329 .addClass( 'webfontMenu' )
330330 .append( $menuItemsDiv );
331 - var $link = $( '<a>' ).prop( 'href', '#' ).text( mw.message( 'webfonts-load' ).escaped() );
 331+ var $link = $( '<a>' )
 332+ .prop( 'href', '#' )
 333+ .text( mw.message( 'webfonts-load' ).escaped() )
 334+ .attr( 'title', mw.msg( 'webfonts-menu-tooltip' ) );
332335 // This is the fonts link
333336 var $li = $( '<li>' ).attr( 'id', 'pt-webfont' ).append( $link );
334337 // If RTL, add to the right of top personal links. Else, to the left
Index: trunk/extensions/WebFonts/WebFonts.i18n.php
@@ -17,13 +17,18 @@
1818 'webfonts-load' => 'Select font',
1919 'webfonts-reset' => 'Reset',
2020 'webfonts-enable-preference' => 'Enable font embedding (WebFonts)',
 21+ 'webfonts-menu-tooltip' => 'Select a font for the page',
2122 );
2223
2324 /** Message documentation (Message documentation)
2425 * @author EugeneZelenko
2526 */
2627 $messages['qqq'] = array(
 28+ 'webfonts' => 'The extension name - WebFonts',
 29+ 'webfonts-desc' => 'short description of the extension',
 30+ 'webfonts-load' => 'The text shown in the webfont link',
2731 'webfonts-reset' => '{{Identical|Reset}}',
 32+ 'webfonts-menu-tooltip' => 'Tooltip text displayed in the webfont link',
2833 );
2934
3035 /** Arabic (العربية)
@@ -321,6 +326,7 @@
322327 'webfonts-load' => 'ഫോണ്ടുകള്‍',
323328 'webfonts-reset' => 'പഴയപടിയാക്കുക',
324329 'webfonts-enable-preference' => 'ഫോണ്ട് എംബെഡ് ചെയ്യുക.(വെബ്ഫോണ്ട്സ്)',
 330+ 'webfonts-menu-tooltip' => 'താളിനുവേണ്ടി ഒരു ഫോണ്ട് തിരഞ്ഞെടുക്കുക',
325331 );
326332
327333 /** Marathi (मराठी)
Index: trunk/extensions/WebFonts/WebFonts.php
@@ -57,7 +57,7 @@
5858 ),
5959 'localBasePath' => $dir,
6060 'remoteExtPath' => 'WebFonts',
61 - 'messages' => array( 'webfonts-load', 'webfonts-reset' ),
 61+ 'messages' => array( 'webfonts-load', 'webfonts-reset', 'webfonts-menu-tooltip' ),
6262 'dependencies' => 'jquery.cookie' ,
6363 'position' => 'top',
6464 );

Follow-up revisions

RevisionCommit summaryAuthorDate
r105900Correct the usage of mw.message with mw.msg, Follow up r105869...santhosh16:31, 12 December 2011

Comments

#Comment by Nikerabbit (talk | contribs)   15:45, 12 December 2011

.text( ...escaped() ) is still double escaping.

Status & tagging log