r105841 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105840‎ | r105841 | r105842 >
Date:00:03, 12 December 2011
Author:robin
Status:ok
Tags:
Comment:
Remove the (useless) configuration option $wgVectorShowVariantName. If set to false (which is default), it is not clear to users what the dropdown menu is about. Secondly, other skins display all variants as different tabs. Thirdly, Serbian and Chinese projects (most active projects relevant to this) have set it to true.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/skins/Vector.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Vector.php
@@ -326,7 +326,7 @@
327327 * @param $elements array
328328 */
329329 private function renderNavigation( $elements ) {
330 - global $wgVectorUseSimpleSearch, $wgVectorShowVariantName;
 330+ global $wgVectorUseSimpleSearch;
331331
332332 // If only one element was given, wrap it in an array, allowing more
333333 // flexible arguments
@@ -355,15 +355,13 @@
356356 case 'VARIANTS':
357357 ?>
358358 <div id="p-variants" class="vectorMenu<?php if ( count( $this->data['variant_urls'] ) == 0 ) echo ' emptyPortlet'; ?>">
359 - <?php if ( $wgVectorShowVariantName ): ?>
360 - <h4>
361 - <?php foreach ( $this->data['variant_urls'] as $link ): ?>
362 - <?php if ( stripos( $link['attributes'], 'selected' ) !== false ): ?>
363 - <?php echo htmlspecialchars( $link['text'] ) ?>
364 - <?php endif; ?>
365 - <?php endforeach; ?>
366 - </h4>
367 - <?php endif; ?>
 359+ <h4>
 360+ <?php foreach ( $this->data['variant_urls'] as $link ): ?>
 361+ <?php if ( stripos( $link['attributes'], 'selected' ) !== false ): ?>
 362+ <?php echo htmlspecialchars( $link['text'] ) ?>
 363+ <?php endif; ?>
 364+ <?php endforeach; ?>
 365+ </h4>
368366 <h5><span><?php $this->msg( 'variants' ) ?></span><a href="#"></a></h5>
369367 <div class="menu">
370368 <ul<?php $this->html( 'userlangattributes' ) ?>>
Index: trunk/phase3/RELEASE-NOTES-1.19
@@ -24,6 +24,7 @@
2525 items to show by default on query pages (special pages such as Whatlinkshere).
2626 * (bug 32470) Increase the length of ug_group.
2727 * (bug 32239) Removed wgEnableTooltipsAndAccesskeys.
 28+* Removed $wgVectorShowVariantName.
2829
2930 === New features in 1.19 ===
3031 * (bug 19838) Possibility to get all interwiki prefixes if the interwiki
Index: trunk/phase3/includes/DefaultSettings.php
@@ -2454,11 +2454,6 @@
24552455 $wgVectorUseIconWatch = false;
24562456
24572457 /**
2458 - * Show the name of the current variant as a label in the variants drop-down menu
2459 - */
2460 -$wgVectorShowVariantName = false;
2461 -
2462 -/**
24632458 * Display user edit counts in various prominent places.
24642459 */
24652460 $wgEdititis = false;

Status & tagging log