r105829 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105828‎ | r105829 | r105830 >
Date:20:47, 11 December 2011
Author:yuvipanda
Status:deferred
Tags:
Comment:
Properly formatted timestamp
Modified paths:
  • /trunk/extensions/SelectionSifter/SelectionSifter.i18n.php (modified) (history)
  • /trunk/extensions/SelectionSifter/SpecialAssessmentLog.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SelectionSifter/SelectionSifter.i18n.php
@@ -23,6 +23,7 @@
2424 'ss-assessment-log' => 'Assessment Log',
2525 'ss-action' => 'Action',
2626 'ss-old' => 'Old Value',
 27+ 'ss-timestamp' => 'Timestamp',
2728 'ss-new' => 'New Value',
2829 'ss-assessment-log-empty' => 'No log entries found'
2930 );
Index: trunk/extensions/SelectionSifter/SpecialAssessmentLog.php
@@ -26,17 +26,17 @@
2727 $out->setPageTitle( $this->msg( 'ss-assessment-log' ) );
2828
2929 $fields = array(
30 - 'Project' => array(
 30+ 'Project' => array(
3131 'type' => 'text',
3232 'label-message' => 'ss-project',
3333 'tabindex' => '1'
34 - )
 34+ )
3535 );
3636
3737 $project = $request->getText( 'wpProject' );
3838
3939 $filters = array_filter( array(
40 - 'l_project' => $project
 40+ 'l_project' => $project
4141 ) );
4242
4343 $form = new HTMLForm( $fields, $this->getContext() );
@@ -55,7 +55,8 @@
5656 Html::element( 'td', array(), wfMessage( 'ss-old' ) ) .
5757 Html::element( 'td', array(), wfMessage( 'ss-new' ) ) .
5858 Html::element( 'td', array(), wfMessage( 'ss-article' ) ) .
59 - Html::element( 'td', array(), wfMessage( 'ss-project' ) )
 59+ Html::element( 'td', array(), wfMessage( 'ss-project' ) ) .
 60+ Html::element( 'td', array(), wfMessage( 'ss-timestamp' ) )
6061 ) .
6162 $pager->getBody() .
6263 '</table>' .
@@ -109,7 +110,7 @@
110111 Html::rawElement( 'td', array(),
111112 Linker::linkKnown( $project_title, htmlspecialchars( $project_title->getText() ) )
112113 ) .
113 - Html::element( 'td', array(), $row->l_timestamp )
 114+ Html::element( 'td', array(), wfTimestamp( TS_DB, $row->l_timestamp ) )
114115 );
115116 }
116117 }

Status & tagging log