r105749 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105748‎ | r105749 | r105750 >
Date:03:28, 10 December 2011
Author:erik
Status:ok
Tags:
Comment:
fix another dependency on removed mw.isDefined function
Modified paths:
  • /trunk/extensions/UploadWizard/resources/mw.UploadWizardDeed.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/resources/mw.UploadWizardDeed.js
@@ -123,9 +123,10 @@
124124 _this.$authorInput2 = $j( '<input type="text" />' ).attr( { name: "author2" } ).addClass( 'mwe-upwiz-sign' );
125125
126126 var defaultLicense = mw.UploadWizard.config.licensesOwnWork.defaults[0];
127 - var defaultLicenseURL = mw.isDefined ( mw.UploadWizard.config.licenses[defaultLicense].url ) ?
128 - mw.UploadWizard.config.licenses[defaultLicense].url :
129 - '#missing license URL';
 127+ var defaultLicenseURL = mw.UploadWizard.config.licenses[defaultLicense].url === undefined ?
 128+ '#missing license URL' :
 129+ mw.UploadWizard.config.licenses[defaultLicense].url;
 130+
130131 var defaultLicenseLink = $j( '<a>' ).attr( { 'target': '_blank', 'href': defaultLicenseURL } );
131132 var $standardDiv = $j( '<div />' ).append(
132133 $j( '<label for="author2" generated="true" class="mwe-validator-error" style="display:block;" />' ),

Status & tagging log