r105746 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105745‎ | r105746 | r105747 >
Date:02:23, 10 December 2011
Author:rsterbin
Status:ok
Tags:
Comment:
Tooltip link now gets swapped out depending on whether a form or a CTA is showing
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
@@ -2149,7 +2149,6 @@
21502150
21512151 // Add the help tooltip
21522152 $wrapper.find( '.articleFeedbackv5-tooltip-link' )
2153 - .attr( 'href', mw.msg( 'articlefeedbackv5-help-tooltip-linkurl' ) )
21542153 .click( function ( e ) {
21552154 e.preventDefault();
21562155 window.open( $( e.target ).attr( 'href' ) );
@@ -2238,6 +2237,10 @@
22392238 $.articleFeedbackv5.$dialog.dialog( 'option', 'title', bucket.getTitle() );
22402239 }
22412240
 2241+ // Set the tooltip link
 2242+ $.articleFeedbackv5.find( '.articleFeedbackv5-tooltip-link' )
 2243+ .attr( 'href', mw.msg( 'articlefeedbackv5-help-tooltip-linkurl' ));
 2244+
22422245 // Do anything special the bucket requires
22432246 if ( 'afterBuild' in bucket ) {
22442247 bucket.afterBuild();
@@ -2375,6 +2378,10 @@
23762379 $.articleFeedbackv5.find( '.articleFeedbackv5-title' ).html( cta.getTitle() );
23772380 }
23782381
 2382+ // Set the tooltip link
 2383+ $.articleFeedbackv5.find( '.articleFeedbackv5-tooltip-link' )
 2384+ .attr( 'href', mw.config.get( 'wgArticleFeedbackv5LearnToEdit' ) );
 2385+
23792386 // Add a close button to clear out the panel
23802387 var $close = $( '<a class="articleFeedbackv5-clear-trigger">x</a>' )
23812388 .click( function (e) {

Status & tagging log