r105718 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105717‎ | r105718 | r105719 >
Date:21:00, 9 December 2011
Author:tparscal
Status:deferred
Tags:
Comment:
Update child leaf nodes on attribute change, not the parent
Modified paths:
  • /trunk/extensions/VisualEditor/modules/es/es.TransactionProcessor.js (modified) (history)

Diff [purge]

Index: trunk/extensions/VisualEditor/modules/es/es.TransactionProcessor.js
@@ -446,7 +446,9 @@
447447 throw 'Invalid method error. Can not operate attributes this way: ' + method;
448448 }
449449 var node = this.model.getNodeFromOffset( this.cursor + 1 );
450 - node.emit( 'update' );
 450+ node.traverseLeafNodes( function( leafNode ) {
 451+ leafNode.emit( 'update' );
 452+ } );
451453 };
452454
453455 es.TransactionProcessor.prototype.mark = function( op, invert ) {

Status & tagging log