r105699 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105698‎ | r105699 | r105700 >
Date:19:25, 9 December 2011
Author:gregchiasson
Status:ok
Tags:
Comment:
AFTv5 - fix bug in rollup tables, that was total to count++, and not changing the count, on rating/boolean submits.
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/api/ApiArticleFeedbackv5.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/api/ApiArticleFeedbackv5.php
@@ -231,7 +231,6 @@
232232 $this->updateRollupRow( $pageId, $revId, $type, $row );
233233 }
234234 }
235 -
236235 }
237236
238237 /**
@@ -342,7 +341,7 @@
343342 'aft_article_revision_feedback_ratings_rollup',
344343 array(
345344 "afrr_total = afrr_total + $value",
346 - "afrr_total = afrr_count + 1",
 345+ "afrr_count = afrr_count + 1",
347346 ),
348347 array(
349348 'afrr_page_id' => $pageId,

Status & tagging log