r105662 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105661‎ | r105662 | r105663 >
Date:09:32, 9 December 2011
Author:tstarling
Status:ok
Tags:
Comment:
Fix for r102295 per CR r105654: don't double-escape the URL
Modified paths:
  • /trunk/phase3/includes/FeedUtils.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/FeedUtils.php
@@ -174,7 +174,7 @@
175175 $queryParameters = ($oldid == null)
176176 ? "diff={$newid}"
177177 : "diff={$newid}&oldid={$oldid}" ;
178 - $diffUrl = $title->escapeFullUrl( $queryParameters );
 178+ $diffUrl = $title->getFullUrl( $queryParameters );
179179
180180 $diffLink = Html::element( 'a', array( 'href' => $diffUrl ),
181181 wfMsgForContent( 'showdiff' ) );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102295bug 29110 - $wgFeedDiffCutoff doesn't affect new pages...hashar16:12, 7 November 2011
r105654Fixes for r102295:...tstarling05:54, 9 December 2011

Status & tagging log