r105557 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105556‎ | r105557 | r105558 >
Date:15:59, 8 December 2011
Author:yonishostak
Status:ok
Tags:
Comment:
AFTv5: fix #32851
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.hooks.php (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.i18n.php (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.php (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.i18n.php
@@ -14,6 +14,7 @@
1515 'articlefeedbackv5-cta1-confirmation-title' => 'Did you know that you can edit this page?',
1616 'articlefeedbackv5-cta1-confirmation-call' => 'Wikipedia works because anyone can edit its articles. Go ahead, give it a try. Be bold!',
1717 'articlefeedbackv5-cta1-learn-how' => 'Learn how to edit',
 18+ 'articlefeedbackv5-cta1-learn-how-url' => 'http://en.wikipedia.org/wiki/Wikipedia:Tutorial',
1819 'articlefeedbackv5-cta1-edit-linktext' => 'Edit this page',
1920
2021 // error messages
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
@@ -1832,6 +1832,10 @@
18331833
18341834 // Start up the block to return
18351835 var $block = $( $.articleFeedbackv5.currentCTA().templates.block );
 1836+
 1837+ // Fill in the tutorial link
 1838+ $block.find( '.articleFeedbackv5-confirmation-learnHow a' )
 1839+ .attr( 'href', mw.msg( 'articlefeedbackv5-cta1-learn-how-url' ) );
18361840
18371841 // Fill in the link
18381842 $block.find( '.articleFeedbackv5-edit-cta-link' )
Index: trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.php
@@ -26,7 +26,7 @@
2727
2828 // Which categories the pages must belong to have the rating widget added (with _ in text)
2929 // Extension is "disabled" if this field is an empty array (as per default configuration)
30 -$wgArticleFeedbackv5Categories = array();
 30+$wgArticleFeedbackv5Categories = array('AFT5');
3131
3232 // Which categories the pages must not belong to have the rating widget added (with _ in text)
3333 $wgArticleFeedbackv5BlacklistCategories = array();
Index: trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.hooks.php
@@ -53,6 +53,7 @@
5454 'articlefeedbackv5-cta1-confirmation-title',
5555 'articlefeedbackv5-cta1-confirmation-call',
5656 'articlefeedbackv5-cta1-learn-how',
 57+ 'articlefeedbackv5-cta1-learn-how-url',
5758 'articlefeedbackv5-cta1-edit-linktext',
5859 'articlefeedbackv5-bucket1-title',
5960 'articlefeedbackv5-bucket1-question-toggle',

Status & tagging log