r105505 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105504‎ | r105505 | r105506 >
Date:00:58, 8 December 2011
Author:yaron
Status:ok
Tags:
Comment:
Fix for r93203 - fixed and simplified setting of values
Modified paths:
  • /trunk/extensions/SemanticForms/includes/forminputs/SF_ComboBoxInput.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/forminputs/SF_ComboBoxInput.php
@@ -58,10 +58,9 @@
5959 count( $other_args['possible_values'] ) > 0 ) {
6060 $values = $other_args['possible_values'];
6161 } elseif ( $autocompleteFieldType == 'values' ) {
62 - $autocompleteValues = explode( ',', $other_args['values'] );
 62+ $values = explode( ',', $other_args['values'] );
6363 } else {
6464 $values = SFUtils::getAutocompleteValues( $autocompletionSource, $autocompleteFieldType );
65 - $autocompleteValues = SFUtils::getAutocompleteValues( $autocompletionSource, $autocompleteFieldType );
6665 }
6766 $autocompletionSource = str_replace( "'", "\'", $autocompletionSource );
6867

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r93203Added handling of 'values' parameter, and of allowed values from propertyyaron16:33, 26 July 2011

Status & tagging log