r105484 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105483‎ | r105484 | r105485 >
Date:23:25, 7 December 2011
Author:tparscal
Status:deferred
Tags:
Comment:
Added vertical margin in calculation of menu position
Modified paths:
  • /trunk/extensions/VisualEditor/modules/es/styles/es.ContextView.css (modified) (history)
  • /trunk/extensions/VisualEditor/modules/es/views/es.ContextView.js (modified) (history)

Diff [purge]

Index: trunk/extensions/VisualEditor/modules/es/styles/es.ContextView.css
@@ -51,7 +51,7 @@
5252 }
5353
5454 .es-contextView-position-below .es-menuView {
55 - top: 3px;
 55+ top: 2px;
5656 }
5757
5858 .es-contextView-panels {
Index: trunk/extensions/VisualEditor/modules/es/views/es.ContextView.js
@@ -105,7 +105,7 @@
106106 }
107107 $menu.css( 'left', menuLeft );
108108 // Position menu on top or bottom depending on viewport
109 - if ( position.top + menuHeight < windowHeight + windowScrollTop ) {
 109+ if ( position.top + menuHeight + ( menuMargin * 2 ) < windowHeight + windowScrollTop ) {
110110 this.$.addClass( 'es-contextView-position-below' );
111111 } else {
112112 this.$.addClass( 'es-contextView-position-above' );

Status & tagging log