r105478 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105477‎ | r105478 | r105479 >
Date:23:03, 7 December 2011
Author:seanheavey
Status:ok (Comments)
Tags:
Comment:
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css
@@ -467,11 +467,17 @@
468468 float: left;
469469 border: none;
470470 }
471 -
472 -.articleFeedbackv5-tooltip {
 471+.articleFeedbackv5-tooltip-wrap {
 472+ float: right;
 473+ position: relative;
 474+}
 475+.articleFeedbackv5-tooltip-wrap:after {
 476+ clear: both;
 477+}
 478+.articleFeedbackv5-tooltip {
473479 position: absolute;
474480 z-index: 15;
475 - top: -165px;
 481+ top: -160px;
476482 right: -105px;
477483 font-size: 12px;
478484 width: 234px;
@@ -517,8 +523,6 @@
518524 width: 26px;
519525 /* @embed */
520526 background: url(images/bg-tooltip-trigger.png) no-repeat;
521 - float: right;
522 - position: relative;
523527 text-indent: -9999px;
524528 }
525529
@@ -791,13 +795,6 @@
792796 padding-bottom: .17em;
793797 }
794798
795 -.articleFeedbackv5-dialog.ui-dialog .articleFeedbackv5-tooltip-trigger {
796 - margin-right: 10px;
797 -}
798 -
799 -.articleFeedbackv5-dialog.ui-dialog .articleFeedbackv5-tooltip {
800 - right: -67px;
801 -}
802799 body .ui-dialog .ui-icon-closethick {
803800 text-indent: -90000px;
804801 width: 23px;
@@ -816,7 +813,7 @@
817814 right: auto !important;
818815 top: auto !important;
819816 width: 23px !important;
820 - margin: 0 !important;
 817+ margin: 0 0 0 10px!important;
821818 padding: 0 !important;
822819 height: auto !important;
823820 }
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
@@ -169,16 +169,18 @@
170170 ',
171171
172172 helpToolTip: '\
173 - <a class="articleFeedbackv5-tooltip-trigger"></a>\
174 - <div class="articleFeedbackv5-tooltip">\
175 - <div class="tooltip-top"></div>\
176 - <div class="tooltip-repeat">\
177 - <h3><html:msg key="help-tooltip-title" /></h3><span class="articleFeedbackv5-tooltip-close">X</span>\
178 - <div class="clear"></div>\
179 - <p class="articleFeedbackv5-tooltip-info"><html:msg key="help-tooltip-info" /></p>\
180 - <p><a target="_blank" class="articleFeedbackv5-tooltip-link"><html:msg key="help-tooltip-linktext" />&nbsp;&gt;&gt;</a></p>\
 173+ <div class="articleFeedbackv5-tooltip-wrap">\
 174+ <a class="articleFeedbackv5-tooltip-trigger"></a>\
 175+ <div class="articleFeedbackv5-tooltip">\
 176+ <div class="tooltip-top"></div>\
 177+ <div class="tooltip-repeat">\
 178+ <h3><html:msg key="help-tooltip-title" /></h3><span class="articleFeedbackv5-tooltip-close">X</span>\
 179+ <div class="clear"></div>\
 180+ <p class="articleFeedbackv5-tooltip-info"><html:msg key="help-tooltip-info" /></p>\
 181+ <p><a target="_blank" class="articleFeedbackv5-tooltip-link"><html:msg key="help-tooltip-linktext" />&nbsp;&gt;&gt;</a></p>\
 182+ </div>\
 183+ <div class="tooltip-bottom"></div>\
181184 </div>\
182 - <div class="tooltip-bottom"></div>\
183185 </div>\
184186 ',
185187
@@ -2131,7 +2133,7 @@
21322134 height: 300,
21332135 dialogClass: 'articleFeedbackv5-dialog',
21342136 resizable: false,
2135 - draggable: true,
 2137+ draggable: false,
21362138 title: $.articleFeedbackv5.currentBucket().getTitle(),
21372139 modal: true,
21382140 autoOpen: false,

Comments

#Comment by Catrope (talk | contribs)   16:53, 12 December 2011

Please provide more verbose commit messages rather than referring to a ticket in a closed bug tracker.

Status & tagging log