r105473 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105472‎ | r105473 | r105474 >
Date:22:50, 7 December 2011
Author:tparscal
Status:deferred
Tags:
Comment:
Fixed the layout of the sandbox and demo
Modified paths:
  • /trunk/extensions/VisualEditor/SpecialVisualEditorSandbox.php (modified) (history)
  • /trunk/extensions/VisualEditor/demo/index.html (modified) (history)
  • /trunk/extensions/VisualEditor/modules/sandbox/sandbox.css (modified) (history)

Diff [purge]

Index: trunk/extensions/VisualEditor/SpecialVisualEditorSandbox.php
@@ -25,6 +25,13 @@
2626 <!-- VisualEditor Sandbox -->
2727 <div id="es-base">
2828 <div id="es-toolbar" class="es-toolbar">
 29+ <div id="es-modes" class="es-modes">
 30+ <div id="es-mode-wikitext" class="es-modes-button"></div>
 31+ <div id="es-mode-json" class="es-modes-button"></div>
 32+ <div id="es-mode-html" class="es-modes-button"></div>
 33+ <div id="es-mode-render" class="es-modes-button"></div>
 34+ <div id="es-mode-history" class="es-modes-button"></div>
 35+ </div>
2936 <div style="clear:both"></div>
3037 <div id="es-toolbar-shadow"></div>
3138 </div>
@@ -32,12 +39,12 @@
3340 <div id="es-visual">
3441 <div id="es-editor"></div>
3542 </div>
36 - <div id="es-previews">
37 - <div id="es-preview-wikitext" class="es-preview es-code"></div>
38 - <div id="es-preview-json" class="es-preview es-code"></div>
39 - <div id="es-preview-html" class="es-preview es-code"></div>
40 - <div id="es-preview-render" class="es-preview es-render"></div>
41 - <div id="es-preview-history" class="es-preview es-history"></div>
 43+ <div id="es-panels">
 44+ <div id="es-panel-wikitext" class="es-panel es-code"></div>
 45+ <div id="es-panel-json" class="es-panel es-code"></div>
 46+ <div id="es-panel-html" class="es-panel es-code"></div>
 47+ <div id="es-panel-render" class="es-panel es-render"></div>
 48+ <div id="es-panel-history" class="es-panel es-code"></div>
4249 </div>
4350 <div style="clear:both"></div>
4451 </div>
Index: trunk/extensions/VisualEditor/demo/index.html
@@ -70,6 +70,7 @@
7171 <div id="es-mode-render" class="es-modes-button"></div>
7272 <div id="es-mode-history" class="es-modes-button"></div>
7373 </div>
 74+ <div style="clear:both"></div>
7475 <div id="es-toolbar-shadow"></div>
7576 </div>
7677 <div id="es-panes">
Index: trunk/extensions/VisualEditor/modules/sandbox/sandbox.css
@@ -39,11 +39,16 @@
4040 }
4141 .es-showData #es-editor {
4242 border-right: solid 1px #cccccc;
 43+ margin: 0;
 44+ padding: 0;
4345 }
4446 .es-showData #es-visual {
 47+ margin: 0;
 48+ padding: 0;
4549 float: left;
46 - width: 49%;
 50+ width: 50%;
4751 overflow: hidden;
 52+ margin-left: -1px;
4853 }
4954 #es-panels {
5055 display: none;
@@ -51,7 +56,7 @@
5257 .es-showData #es-panels {
5358 display: block;
5459 float: right;
55 - width: 48%;
 60+ width: 50%;
5661 overflow: hidden;
5762 }
5863 .es-panel {
@@ -95,10 +100,12 @@
96101 .mediawiki .es-menuView {
97102 font-size: 0.8em;
98103 }
 104+
 105+#es-toolbar .es-toolbarGroups {
 106+ float: left;
 107+}
99108 .es-modes {
100 - position: absolute;
101 - right: 0;
102 - top: 0;
 109+ float: right;
103110 padding: 0.25em;
104111 }
105112 .es-modes-button {

Status & tagging log