r105463 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105462‎ | r105463 | r105464 >
Date:21:39, 7 December 2011
Author:gregchiasson
Status:ok
Tags:
Comment:
on AFTv5 feedback page, hide the initial text, use text instead of html in a few more places.
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.js
@@ -63,7 +63,7 @@
6464 },
6565 'success': function ( data ) {
6666 // TODO check output and error if needed
67 - $( '#aft5-' + type + '-link-' + id ).html(
 67+ $( '#aft5-' + type + '-link-' + id ).text(
6868 mw.msg( 'articlefeedbackv5-' + type + '-saved' )
6969 );
7070 }
@@ -99,7 +99,7 @@
100100 }
101101
102102 } else {
103 - $( '#aft5-show-feedback' ).html( mw.msg( 'articlefeedbackv5-error-loading-feedback' ) );
 103+ $( '#aft5-show-feedback' ).text( mw.msg( 'articlefeedbackv5-error-loading-feedback' ) );
104104 }
105105 }
106106 // TODO: have a callback for failures.
@@ -110,6 +110,8 @@
111111 } )( jQuery );
112112
113113 $( document ).ready( function() {
 114+ // Blank out the 'loading' text
 115+ $( '#aft5-show-feedback' ).text( ' ' );
114116 $.articleFeedbackv5special.setBinds();
115117 $.articleFeedbackv5special.loadFeedback();
116118 } );

Status & tagging log