r105426 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105425‎ | r105426 | r105427 >
Date:12:49, 7 December 2011
Author:santhosh
Status:ok
Tags:
Comment:
CSS cleanup,
Dont wait, just show the menu without animation
And some spaces.
Follow up r105281
Modified paths:
  • /trunk/extensions/Narayam/resources/ext.narayam.core.css (modified) (history)
  • /trunk/extensions/Narayam/resources/ext.narayam.core.js (modified) (history)

Diff [purge]

Index: trunk/extensions/Narayam/resources/ext.narayam.core.css
@@ -67,11 +67,7 @@
6868 x:-moz-any-link {
6969 margin-left: 23px;
7070 }
71 -/* Enable forcing showing of the menu for accessibility */
72 -div#narayam-menu:hover div.menu-items,
73 -div#narayam-menu div.menuForceShow {
74 - display: block;
75 -}
 71+
7672 div#narayam-menu ul {
7773 position: absolute;
7874 background-color: white;
@@ -90,34 +86,13 @@
9187 max-height: 360px;
9288 overflow-y: auto;
9389 }
94 -/* Fixes old versions of FireFox */
95 -div#narayam-menu ul,
96 -x:-moz-any-link {
97 - min-width: 5em;
98 -}
99 -/* Returns things back to normal in modern versions of FireFox */
100 -div#narayam-menu ul,
101 -x:-moz-any-link,
102 -x:default {
103 - min-width: 0;
104 -}
 90+
10591 div#narayam-menu li {
106 -/* padding: 0;*/
10792 margin: 0;
10893 text-align: left;
10994 line-height: 1em;
11095 }
111 -/* OVERRIDDEN BY COMPLIANT BROWSERS */
112 -div#narayam-menu li a {
113 - display: inline-block;
114 - padding: 0.5em;
115 - white-space: nowrap;
116 - color: #0645ad;
117 -}
118 -/* IGNORED BY IE6 */
119 -div#narayam-menu li > a {
120 - display: block;
121 -}
 96+
12297 div#narayam-menu li.selected a,
12398 div#narayam-menu li.selected a:visited {
12499 color: #333333;
Index: trunk/extensions/Narayam/resources/ext.narayam.core.js
@@ -652,15 +652,15 @@
653653 // If rtl, add to the right of top personal links. Else, to the left
654654 var fn = $( 'body' ).hasClass( 'rtl' ) ? "append" : "prepend";
655655 $( '#p-personal ul:first' )[fn]( $li );
656 - $( 'body').prepend($menu);
 656+ $( 'body' ).prepend( $menu );
657657 $menu.hide();
658658 $li.hover( function() {
659659 $menuItemsDiv.css( 'left', $li.offset().left );
660 - $menu.slideDown( 'slow' );
 660+ $menu.show();
661661 });
662662 $menu.hover( function() {
663663 }, function() {
664 - $menu.slideUp( 'slow' );
 664+ $menu.hide();
665665 });
666666
667667 // Workaround for IE bug - activex components like input fields

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r105281Fix Narayam for monobook skin(Bug 32124)...santhosh10:02, 6 December 2011

Status & tagging log