r105424 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105423‎ | r105424 | r105425 >
Date:11:56, 7 December 2011
Author:gwicke
Status:deferred
Tags:
Comment:
Follow-up to r105423: Fix off-by-one bug.
Modified paths:
  • /trunk/extensions/VisualEditor/modules/parser/pegParser.pegjs.txt (modified) (history)

Diff [purge]

Index: trunk/extensions/VisualEditor/modules/parser/pegParser.pegjs.txt
@@ -200,7 +200,7 @@
201201 var txt = out[index - 1];
202202 txt.value += "'";
203203 if ( i > 0 ) {
204 - bolds = bolds.slice(0, i-1)
 204+ bolds = bolds.slice(0, i)
205205 .concat(bolds.slice(i + 1, bolds.length - i - 1));
206206 } else {
207207 bolds.shift();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r105423Fix a bug in doQuotes (bitten by surprising JS sort() behavior), and improve...gwicke11:51, 7 December 2011

Status & tagging log