r105402 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105401‎ | r105402 | r105403 >
Date:01:12, 7 December 2011
Author:inez
Status:deferred
Tags:
Comment:
Make ListView.enumerate method clear ListItemView.$icon when item is not 'number'.
Modified paths:
  • /trunk/extensions/VisualEditor/modules/es/views/es.ListItemView.js (modified) (history)
  • /trunk/extensions/VisualEditor/modules/es/views/es.ListView.js (modified) (history)

Diff [purge]

Index: trunk/extensions/VisualEditor/modules/es/views/es.ListItemView.js
@@ -47,10 +47,6 @@
4848 }
4949 };
5050
51 -es.ListItemView.prototype.setNumber = function( number ) {
52 - this.$icon.text( number + '.' );
53 -};
54 -
5551 /* Registration */
5652
5753 es.DocumentView.splitRules.listItem = {
Index: trunk/extensions/VisualEditor/modules/es/views/es.ListView.js
@@ -37,7 +37,9 @@
3838 if ( !levels[styles.length - 1] ) {
3939 levels[styles.length - 1] = 0;
4040 }
41 - this.children[i].setNumber( ++levels[styles.length - 1] );
 41+ this.children[i].$icon.text( number + '.' );
 42+ } else {
 43+ this.children[i].$icon.text( '' );
4244 }
4345 }
4446 };

Status & tagging log