r105397 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105396‎ | r105397 | r105398 >
Date:00:49, 7 December 2011
Author:preilly
Status:ok
Tags:
Comment:
more spacing issues and line length
Modified paths:
  • /trunk/extensions/MobileFrontend/MobileFrontend.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/MobileFrontend.php
@@ -436,13 +436,13 @@
437437 } catch ( Exception $e ) {
438438 // echo $e->getMessage();
439439 }
440 -
 440+
441441 // Note: The WebRequest Class calls are made in this block because
442442 // since PHP 5.1.x, all objects have their destructors called
443443 // before the output buffer callback function executes.
444444 // Thus, globalized objects will not be available as expected in the function.
445445 // This is stated to be intended behavior, as per the following: [http://bugs.php.net/bug.php?id=40104]
446 -
 446+
447447 $xDevice = isset( $_SERVER['HTTP_X_DEVICE'] ) ? $_SERVER['HTTP_X_DEVICE'] : '';
448448 self::$useFormat = $wgRequest->getText( 'useformat' );
449449 $mobileAction = $wgRequest->getText( 'mobileaction' );
@@ -1031,9 +1031,7 @@
10321032 wfProfileIn( __METHOD__ );
10331033 $itemToRemoveRecords = array();
10341034
1035 - foreach ( array_merge( $this->itemsToRemove, $wgMFRemovableClasses )
1036 - as $itemToRemove )
1037 - {
 1035+ foreach ( array_merge( $this->itemsToRemove, $wgMFRemovableClasses ) as $itemToRemove ) {
10381036 $type = '';
10391037 $rawName = '';
10401038 CssDetection::detectIdCssOrTag( $itemToRemove, $type, $rawName );

Status & tagging log