r105359 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105358‎ | r105359 | r105360 >
Date:21:30, 6 December 2011
Author:khorn
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_common/DonationData.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_common/gateway.adapter.php (modified) (history)

Diff [purge]

Index: branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_common/gateway.adapter.php
@@ -799,6 +799,8 @@
800800 $this->transaction_results = array();
801801 $this->setValidationAction('process', true);
802802
 803+ $this->log( 'ReferrerHeaderTest (' . $this->getData_Raw( 'contribution_tracking_id' ) . "): Value @ do_transaction = " . $this->getData_Raw( 'referrer' ) );
 804+
803805 try {
804806 $this->setCurrentTransaction( $transaction );
805807
@@ -1277,7 +1279,7 @@
12781280 $start[$string] = $now;
12791281 }
12801282 $clock = round( $now - $start[$string], 4 );
1281 - self::log( "\nClock at $string: $clock ($now)" );
 1283+ self::log( "Clock at $string: $clock ($now)" );
12821284 return $clock;
12831285 }
12841286
Property changes on: branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_common/gateway.adapter.php
___________________________________________________________________
Modified: svn:mergeinfo
12851287 Merged /trunk/extensions/DonationInterface/gateway_common/gateway.adapter.php:r105334
Index: branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_common/DonationData.php
@@ -107,6 +107,19 @@
108108 }
109109 }
110110
 111+ $posted_referrer = $wgRequest->getVal( 'referrer' );
 112+ $tries = array(
 113+ 'referer',
 114+ 'referrer',
 115+ 'Referer',
 116+ 'Referrer'
 117+ );
 118+ foreach ($tries as $trythis){
 119+ $header[$trythis] = $wgRequest->getHeader( $trythis );
 120+ }
 121+
 122+ $this->log( 'ReferrerHeaderTest (' . $this->getVal( 'contribution_tracking_id' ) . "): Posted = $posted_referrer, Header Tries = " . print_r($header, true) . ', Final = ' . $this->getVal('referrer') );
 123+
111124 //if we have saved any donation data to the session, pull them in as well.
112125 $this->integrateDataFromSession();
113126
@@ -140,6 +153,7 @@
141154 }
142155 }
143156 }
 157+ $this->log( 'ReferrerHeaderTest (' . $this->getVal( 'contribution_tracking_id' ) . "): Final After Session Integration = " . $this->getVal('referrer') );
144158 }
145159
146160 function getData() {
Property changes on: branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_common/DonationData.php
___________________________________________________________________
Modified: svn:mergeinfo
147161 Merged /trunk/extensions/DonationInterface/gateway_common/DonationData.php:r105334

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r105334More logging in order to pinpoint the place where the referrer is going missing.khorn18:55, 6 December 2011

Status & tagging log