r105335 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105334‎ | r105335 | r105336 >
Date:18:59, 6 December 2011
Author:demon
Status:ok
Tags:
Comment:
Use HTML in views html heredocs so smart editors can syntax highlight
Modified paths:
  • /trunk/extensions/MobileFrontend/views/information/disable.html.php (modified) (history)
  • /trunk/extensions/MobileFrontend/views/information/leave_feedback.html.php (modified) (history)
  • /trunk/extensions/MobileFrontend/views/information/optin.html.php (modified) (history)
  • /trunk/extensions/MobileFrontend/views/information/optout.html.php (modified) (history)
  • /trunk/extensions/MobileFrontend/views/layout/_footmenu_default.html.php (modified) (history)
  • /trunk/extensions/MobileFrontend/views/layout/_search_webkit.html.php (modified) (history)
  • /trunk/extensions/MobileFrontend/views/layout/application.html.php (modified) (history)
  • /trunk/extensions/MobileFrontend/views/layout/application.wml.php (modified) (history)
  • /trunk/extensions/MobileFrontend/views/notices/_donate.html.php (modified) (history)
  • /trunk/extensions/MobileFrontend/views/notices/notice_1.html.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/views/notices/_donate.html.php
@@ -1,9 +1,9 @@
22 <?php
33
4 -$donateHtml = <<<EOT
 4+$donateHtml = <<<HTML
55 <div class='mwm-message mwm-notice'>
66 Text WIKI to <a href="sms:25383">25383</a> to donate $10.
77 <br />
88 <a href='http://wikimediafoundation.org/wiki/Mobile_Giving'>Msg & Data Rates May Apply</a>
99 </div>
10 -EOT;
 10+HTML;
Index: trunk/extensions/MobileFrontend/views/notices/notice_1.html.php
@@ -2,8 +2,8 @@
33
44 $thanks = self::$messages['mobile-frontend-leave-feedback-thanks'];
55
6 -$noticeHtml = <<<EOT
 6+$noticeHtml = <<<HTML
77 <div class='mwm-message mwm-notice'>
88 {$thanks}
99 </div>
10 -EOT;
 10+HTML;
Index: trunk/extensions/MobileFrontend/views/information/optin.html.php
@@ -1,5 +1,5 @@
22 <?php
3 -$optInHtml = <<<EOT
 3+$optInHtml = <<<HTML
44 <h1>
55 {$optInMessage}
66 </h1>
@@ -16,4 +16,4 @@
1717 <button id='backButton' type='submit'>{$noButton}</button>
1818 </form>
1919 </div>
20 -EOT;
 20+HTML;
Index: trunk/extensions/MobileFrontend/views/information/optout.html.php
@@ -1,5 +1,5 @@
22 <?php
3 -$optOutHtml = <<<EOT
 3+$optOutHtml = <<<HTML
44 <h1>
55 {$optOutMessage}
66 </h1>
@@ -16,4 +16,4 @@
1717 <button id='backButton' type='submit'>{$noButton}</button>
1818 </form>
1919 </div>
20 -EOT;
 20+HTML;
Index: trunk/extensions/MobileFrontend/views/information/leave_feedback.html.php
@@ -1,6 +1,6 @@
22 <?php
33
4 -$leaveFeedbackHtml = <<<EOT
 4+$leaveFeedbackHtml = <<<HTML
55 <form action='{$feedbackPostURL}' method='post'>
66 <input type="hidden" name="edittoken" value="{$editToken}"/>
77 <div tabindex="-1">
@@ -23,4 +23,4 @@
2424 </div>
2525 </form>
2626
27 -EOT;
 27+HTML;
Index: trunk/extensions/MobileFrontend/views/information/disable.html.php
@@ -4,7 +4,7 @@
55 $currentURL = str_replace( '&mobileaction=disable_mobile_site', '', $currentURL );
66 $mobileRedirectFormAction = self::$mobileRedirectFormAction;
77
8 -$disableHtml = <<<EOT
 8+$disableHtml = <<<HTML
99 <h1>
1010 {$areYouSure}
1111 </h1>
@@ -21,4 +21,4 @@
2222 <button id='backButton' type='submit'>{$backButton}</button>
2323 </form>
2424 </div>
25 -EOT;
 25+HTML;
Index: trunk/extensions/MobileFrontend/views/layout/_search_webkit.html.php
@@ -20,7 +20,7 @@
2121
2222 $logoOnClick = ( self::$device['supports_javascript'] ) ? 'onclick="javascript:logoClick();"' : '';
2323
24 -$searchWebkitHtml = <<<EOD
 24+$searchWebkitHtml = <<<HTML
2525 {$openSearchResults}
2626 <div id='header'>
2727 <div id='searchbox' {$logoDisplayNone}>
@@ -40,4 +40,4 @@
4141 <button onclick="javascript:location.href='{$randomPageUrl}';" type="submit" id="randomButton">{$randomButton}</button>
4242 </div>
4343 </div>
44 -EOD;
 44+HTML;
Index: trunk/extensions/MobileFrontend/views/layout/application.wml.php
@@ -4,7 +4,7 @@
55 $dir = self::$dir;
66 $code = self::$code;
77
8 -$applicationHtml = <<<EOT
 8+$applicationHtml = <<<HTML
99 <?xml version='1.0' encoding='utf-8' ?>
1010 <!DOCTYPE wml PUBLIC "-//WAPFORUM//DTD WML 1.3//EN"
1111 "http://www.wapforum.org/DTD/wml13.dtd">
@@ -19,4 +19,4 @@
2020 </template>
2121 {$contentHtml}
2222 </wml>
23 -EOT;
 23+HTML;
Index: trunk/extensions/MobileFrontend/views/layout/_footmenu_default.html.php
@@ -23,7 +23,7 @@
2424
2525 $feedbackLink = ( self::$code == 'en' && self::$isBetaGroupMember ) ? "| <a href=\"{$leaveFeedbackURL}\">{$leaveFeedback}</a>" : '';
2626
27 -$footerHtml = <<<EOD
 27+$footerHtml = <<<HTML
2828 <div id='footer'>
2929 <div class='nav' id='footmenu'>
3030 <div class='mwm-notice'>
@@ -36,4 +36,4 @@
3737 <div id='copyright'>{$copyright}</div>
3838 </div>
3939
40 -EOD;
 40+HTML;
Index: trunk/extensions/MobileFrontend/views/layout/application.html.php
@@ -23,7 +23,7 @@
2424
2525 $openSearchScript = $startScriptTag . $javaScriptPath . $betaPrefix . 'opensearch.js?version=12012011126437' . $endScriptTag;
2626
27 -$applicationHtml = <<<EOT
 27+$applicationHtml = <<<HTML
2828 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
2929 "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
3030 <html lang='{$code}' dir='{$dir}' xml:lang='{$code}' xmlns='http://www.w3.org/1999/xhtml'>
@@ -57,4 +57,4 @@
5858 {$openSearchScript}
5959 </body>
6060 </html>
61 -EOT;
 61+HTML;

Status & tagging log