r105279 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105278‎ | r105279 | r105280 >
Date:09:35, 6 December 2011
Author:hashar
Status:ok
Tags:
Comment:
uidesign: fix diffchange, show basic diff just like on wiki
Modified paths:
  • /trunk/phase3/docs/uidesign/mediawiki.action.history.diff.html (modified) (history)

Diff [purge]

Index: trunk/phase3/docs/uidesign/mediawiki.action.history.diff.html
@@ -3,16 +3,36 @@
44 <head>
55 <link rel="stylesheet" href="../../resources/mediawiki.action/mediawiki.action.history.diff.css" />
66 </head>
7 -<body>
 7+<body style="background-color: #C0C0C0;">
88 <p>
9 -This show various styles for our diff action. The reference style sheet is:</p>
 9+This show various styles for our diff action, the background being hardcoded to gray (<tt>#C0C0C0</tt>) The reference style sheet is:</p>
1010 <p>
1111 <tt><a href="../../resources/mediawiki.action/mediawiki.action.history.diff.css">resources/mediawiki.action/mediawiki.action.history.diff.css</a></tt>.
1212 </p>
1313 <p>
1414 This file might help us fix our diff colors which have been a recurring issues among the community for a loooong time.</p>
 15+
 16+<p>
 17+First, show the diff mostly like it would be chown on a wiki</p>
1518 <table class="diff">
 19+<tr>
 20+ <td class="diff-marker">-</td>
 21+ <td class="diff-deletedline"><div>
 22+ Some content <span class="diffchange diffchange-inline">deleted / replaced</span>
 23+ </div></td>
 24+ <td class="diff-marker">+</td>
 25+ <td class="diff-addedline"><div>
 26+ Some content <span class="diffchange diffchange-inline">added / replacement</span>
 27+ </div></td>
 28+</tr>
 29+</table>
1630
 31+
 32+<p>
 33+Below are some basic lines being applied one or two classes. Mainly for debugging purposes</p>
 34+
 35+<table class="diff">
 36+
1737 <tr><th>Diff</th></tr>
1838
1939 <tr><td class="diff-addedline"><tt>diff-addedline</tt>: added line</td></tr>
@@ -20,12 +40,18 @@
2141 <tr><td class="diff-context"><tt>diff-context</tt>: context</td></tr>
2242
2343
24 - <tr><th>Same as above with <tt>diffchange</tt> class</th></tr>
 44+ <tr><th>Same as above with a <tt>&lt;span&gt;</tt> child element having the <tt>diffchange</tt> class</th></tr>
2545
2646 <tr><td class="diffchange">Diffchange</td></tr>
27 - <tr><td class="diff-addedline diffchange">Added line + diffchange</td></tr>
28 - <tr><td class="diff-deletedline diffchange">Deleted line + diffchange</td></tr>
29 - <tr><td class="diff-context diffchange">Context + diffchange</td></tr>
 47+ <tr><td class="diff-addedline">
 48+ <span class="diffchange">Added line + diffchange</span>
 49+ </td></tr>
 50+ <tr><td class="diff-deletedline">
 51+ <span class="diffchange">Deleted line + diffchange</span>
 52+ </td></tr>
 53+ <tr><td class="diff-context">
 54+ <span class="diffchange">Context + diffchange</span>
 55+ </td></tr>
3056 </table>
3157
3258 </body></html>

Status & tagging log