r105262 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105261‎ | r105262 | r105263 >
Date:00:25, 6 December 2011
Author:rsterbin
Status:ok
Tags:
Comment:
Fixed comment to match code in ArticleFeedbackv5.php; dropped debug lines in ArticleFeedbackv5.hooks.php
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.hooks.php (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.php
@@ -117,10 +117,10 @@
118118 // Bucket settings for links to the feedback form
119119 $wgArticleFeedbackv5LinkBuckets = array(
120120 // Users can fall into one of several buckets for links. These are:
121 - // 0: No link; user must scroll to the bottom of the page
122 - // 1: Section bars
123 - // 2: Title bar
124 - // 3: Vertical button
 121+ // -: No link; user must scroll to the bottom of the page
 122+ // A: Section bars
 123+ // B: Title bar
 124+ // C: Vertical button
125125 'buckets' => array(
126126 '-' => 0,
127127 'A' => 0,
Index: trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.hooks.php
@@ -290,12 +290,6 @@
291291 $ctaId = $wgRequest->getVal( 'articleFeedbackv5_cta_id' );
292292 $bucketId = $wgRequest->getVal( 'articleFeedbackv5_bucket_id' );
293293
294 -error_log('Tracking!');
295 -error_log(var_export($feedbackId, true));
296 -error_log(var_export($ctaId, true));
297 -error_log(var_export($bucketId, true));
298 -error_log(var_export($article->getTitle()->getText(), true));
299 -
300294 return true;
301295 }
302296

Status & tagging log