r105250 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105249‎ | r105250 | r105251 >
Date:23:53, 5 December 2011
Author:awjrichards
Status:ok
Tags:
Comment:
MFT r104223 (partial - excluding bannerstats.js), r105147
Modified paths:
  • /branches/wmf/1.18wmf1/extensions/CentralNotice/CentralNotice.db.php (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/CentralNotice/special/SpecialBannerAllocation.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/CentralNotice/special/SpecialBannerAllocation.php
@@ -178,11 +178,11 @@
179179 }
180180 }
181181
182 - if ( $anonBanners ) {
 182+ if ( $anonBanners && $anonWeight > 0 ) {
183183 $htmlOut .= $this->getTable( wfMsg ( 'centralnotice-banner-anonymous' ), $anonBanners, $anonWeight );
184184 }
185185
186 - if ( $accountBanners ) {
 186+ if ( $accountBanners && $accountWeight > 0 ) {
187187 $htmlOut .= $this->getTable( wfMsg ( 'centralnotice-banner-logged-in' ), $accountBanners, $accountWeight );
188188 }
189189 } else {
@@ -203,7 +203,7 @@
204204 $viewCampaign = $this->getTitleFor( 'CentralNotice' );
205205
206206 $htmlOut = Html::openElement( 'table',
207 - array ( 'cellpadding' => 9, 'class' => 'wikitable sortable', 'style' => 'margin: 1em;' )
 207+ array ( 'cellpadding' => 9, 'class' => 'wikitable sortable', 'style' => 'margin: 1em 0;' )
208208 );
209209 $htmlOut .= Html::element( 'caption', array( 'style' => 'font-size: 1.2em;' ), $type );
210210 $htmlOut .= Html::openElement( 'tr' );
Property changes on: branches/wmf/1.18wmf1/extensions/CentralNotice/special/SpecialBannerAllocation.php
___________________________________________________________________
Modified: svn:mergeinfo
211211 Merged /trunk/extensions/CentralNotice/special/SpecialBannerAllocation.php:r104223
Index: branches/wmf/1.18wmf1/extensions/CentralNotice/CentralNotice.db.php
@@ -456,7 +456,7 @@
457457 'CR'=>'Costa Rica',
458458 'CI'=>'Côte d\'Ivoire',
459459 'HR'=>'Croatia',
460 - 'CU'=>'Cuba',
 460+ //'CU'=>'Cuba',
461461 'CY'=>'Cyprus',
462462 'CZ'=>'Czech Republic',
463463 'DK'=>'Denmark',
@@ -502,7 +502,7 @@
503503 'IS'=>'Iceland',
504504 'IN'=>'India',
505505 'ID'=>'Indonesia',
506 - 'IR'=>'Iran',
 506+ //'IR'=>'Iran',
507507 'IQ'=>'Iraq',
508508 'IE'=>'Ireland',
509509 'IL'=>'Israel',
@@ -610,7 +610,7 @@
611611 'SZ'=>'Swaziland',
612612 'SE'=>'Sweden',
613613 'CH'=>'Switzerland',
614 - 'SY'=>'Syrian Arab Republic',
 614+ //'SY'=>'Syrian Arab Republic',
615615 'TW'=>'Taiwan',
616616 'TJ'=>'Tajikistan',
617617 'TZ'=>'Tanzania',
Property changes on: branches/wmf/1.18wmf1/extensions/CentralNotice/CentralNotice.db.php
___________________________________________________________________
Modified: svn:mergeinfo
618618 Merged /trunk/extensions/CentralNotice/CentralNotice.db.php:r105147

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r104223fixing rare divide by zero bug, fixing table formatting, commenting out conso...kaldari06:49, 25 November 2011
r105147commenting out FORBIDDEN countrieskaldari02:45, 5 December 2011

Status & tagging log