r105230 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105229‎ | r105230 | r105231 >
Date:21:39, 5 December 2011
Author:tparscal
Status:deferred
Tags:
Comment:
Fixed annotation tool - data is used generically outside, shouldn't have changed that
Modified paths:
  • /trunk/extensions/VisualEditor/modules/es/tools/es.AnnotationButtonTool.js (modified) (history)

Diff [purge]

Index: trunk/extensions/VisualEditor/modules/es/tools/es.AnnotationButtonTool.js
@@ -8,12 +8,12 @@
99 * @param {String} name
1010 * @param {Object} annotation
1111 */
12 -es.AnnotationButtonTool = function( toolbar, name, annotation ) {
 12+es.AnnotationButtonTool = function( toolbar, name, data ) {
1313 // Inheritance
1414 es.ButtonTool.call( this, toolbar, name );
1515
1616 // Properties
17 - this.annotation = annotation;
 17+ this.annotation = data;
1818 };
1919
2020 /* Methods */
@@ -51,19 +51,19 @@
5252 es.Tool.tools.bold = {
5353 constructor: es.AnnotationButtonTool,
5454 name: 'bold',
55 - annotation: { 'type': 'textStyle/bold' }
 55+ data: { 'type': 'textStyle/bold' }
5656 };
5757
5858 es.Tool.tools.italic = {
5959 constructor: es.AnnotationButtonTool,
6060 name: 'italic',
61 - annotation: { 'type': 'textStyle/italic' }
 61+ data: { 'type': 'textStyle/italic' }
6262 };
6363
6464 es.Tool.tools.link = {
6565 constructor: es.AnnotationButtonTool,
6666 name: 'link',
67 - annotation: { 'type': 'link/internal', 'data': { 'title': '' } }
 67+ data: { 'type': 'link/internal', 'data': { 'title': '' } }
6868 };
6969
7070 /* Inheritance */

Status & tagging log