r105213 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105212‎ | r105213 | r105214 >
Date:20:10, 5 December 2011
Author:inez
Status:deferred
Tags:
Comment:
Fix for getContentText method. Do not treat content offsets with annotations as elements.
Modified paths:
  • /trunk/extensions/VisualEditor/modules/es/bases/es.DocumentModelNode.js (modified) (history)

Diff [purge]

Index: trunk/extensions/VisualEditor/modules/es/bases/es.DocumentModelNode.js
@@ -268,7 +268,7 @@
269269 var text = '',
270270 element = false;
271271 for ( var i = 0, length = content.length; i < length; i++ ) {
272 - if ( typeof content[i] === 'object' ) {
 272+ if ( typeof content[i].type === 'string' ) {
273273 if ( i ) {
274274 element = true;
275275 }

Status & tagging log