r105201 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105200‎ | r105201 | r105202 >
Date:18:38, 5 December 2011
Author:tparscal
Status:deferred
Tags:
Comment:
Prevent cancel link from changing url
Modified paths:
  • /trunk/extensions/VisualEditor/modules/es/views/es.ContextView.js (modified) (history)

Diff [purge]

Index: trunk/extensions/VisualEditor/modules/es/views/es.ContextView.js
@@ -49,8 +49,10 @@
5050 '<div><a href="#cancel">Cancel</a> <button>Change</button></div>' +
5151 '</div>'
5252 );
53 - this.$panels.find( '[href="#cancel"]' ).click( function() {
 53+ this.$panels.find( '[href="#cancel"]' ).click( function( e ) {
5454 _this.$panels.children().hide();
 55+ e.preventDefault();
 56+ return false;
5557 } );
5658
5759 // Events

Status & tagging log