r105146 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105145‎ | r105146 | r105147 >
Date:02:29, 5 December 2011
Author:johnduhart
Status:ok
Tags:
Comment:
Type hinting please
Modified paths:
  • /trunk/phase3/includes/Namespace.php (modified) (history)
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Title.php
@@ -1951,7 +1951,7 @@
19521952 * Please make use of this instead of comparing to getNamespace()
19531953 * This function is much more resistant to changes we may make
19541954 * to namespaces than code that makes direct comparisons.
1955 - * @param $ns The namespace
 1955+ * @param $ns int The namespace
19561956 * @return bool
19571957 * @since 1.19
19581958 */
Index: trunk/phase3/includes/Namespace.php
@@ -155,8 +155,8 @@
156156 * of this function rather than directly doing comparison will make
157157 * sure that code will not potentially break.
158158 *
159 - * @param $ns1 The first namespace index
160 - * @param $ns2 The second namespae index
 159+ * @param $ns1 int The first namespace index
 160+ * @param $ns2 int The second namespae index
161161 *
162162 * @return bool
163163 * @since 1.19
@@ -170,8 +170,8 @@
171171 * eg: NS_USER and NS_USER wil return true, as well
172172 * NS_USER and NS_USER_TALK will return true.
173173 *
174 - * @param $ns1 The first namespace index
175 - * @param $ns2 The second namespae index
 174+ * @param $ns1 int The first namespace index
 175+ * @param $ns2 int The second namespae index
176176 *
177177 * @return bool
178178 * @since 1.19

Status & tagging log