r105091 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105090‎ | r105091 | r105092 >
Date:23:16, 3 December 2011
Author:foxtrott
Status:deferred
Tags:
Comment:
bugfix (version compare)
Modified paths:
  • /trunk/extensions/SemanticFormsInputs/SemanticFormsInputs.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticFormsInputs/SemanticFormsInputs.php
@@ -27,7 +27,7 @@
2828 die( '<b>Error:</b> <a href="https://www.mediawiki.org/wiki/Extension:Semantic_Forms_Inputs">Semantic Forms Inputs</a> is a Semantic Forms extension. You need to install <a href="https://www.mediawiki.org/wiki/Extension:Semantic_Forms">Semantic Forms</a> first.' );
2929 }
3030
31 -if ( version_compare( '2.3.1', SF_VERSION ) != -1 ) {
 31+if ( version_compare( SF_VERSION, '2.3.1', 'lt' ) ) {
3232 die( '<b>Error:</b> This version of <a href="https://www.mediawiki.org/wiki/Extension:Semantic_Forms_Inputs">Semantic Forms Inputs</a> is only compatible with Semantic Forms 2.3.1 or above. You need to upgrade <a href="https://www.mediawiki.org/wiki/Extension:Semantic_Forms">Semantic Forms</a> first.' );
3333 }
3434