r105074 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105073‎ | r105074 | r105075 >
Date:19:02, 3 December 2011
Author:jeroendedauw
Status:reverted
Tags:
Comment:
Follow up to r105073;
Modified paths:
  • /trunk/extensions/Reviews/Reviews.php (modified) (history)
  • /trunk/extensions/Reviews/includes/ReviewPager.php (modified) (history)
  • /trunk/extensions/Reviews/resources/reviews.pager.js (modified) (history)

Diff [purge]

Index: trunk/extensions/Reviews/includes/ReviewPager.php
@@ -158,8 +158,7 @@
159159 }
160160 break;
161161 case 'review_rating':
162 - // TODO: might want to display stars here as well.
163 - $value = $this->getLanguage()->formatNum( $value );
 162+ $value = $this->currentReview->getRating()->getDisplayHTML();
164163 break;
165164 }
166165
Index: trunk/extensions/Reviews/Reviews.php
@@ -215,7 +215,7 @@
216216 'reviews.pager.js',
217217 ),
218218 'dependencies' => array(
219 - 'jquery.reviewState',
 219+ 'jquery.reviewState', 'jquery.reviewRating',
220220 ),
221221 );
222222
Index: trunk/extensions/Reviews/resources/reviews.pager.js
@@ -14,6 +14,8 @@
1515 $( e ).reviewState();
1616 } );
1717
 18+ $( '.review-rating-display' ).reviewRating();
 19+
1820 } );
1921
2022 })( window.jQuery, window.mediaWiki );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r105073work on review rating displayjeroendedauw18:48, 3 December 2011

Status & tagging log