r105037 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105036‎ | r105037 | r105038 >
Date:01:00, 3 December 2011
Author:gregchiasson
Status:deferred
Tags:
Comment:
AFTv5 - internationalize the 'about' URL, in addition to the link text, and correct the transparency link. Internationalizing that link wasn't a requirement, so it's not been done.
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.hooks.php (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.i18n.php (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.i18n.php
@@ -136,9 +136,10 @@
137137 'articlefeedbackv5-help-tooltip-title' => 'What\'s this?',
138138 'articlefeedbackv5-help-tooltip-info' => 'Wikipedia would like to hear what you think of this article. Share your feedback with the editors -- and help improve this page.',
139139 'articlefeedbackv5-help-tooltip-linktext' => 'Learn more',
 140+ 'articlefeedbackv5-help-tooltip-linkurl' => 'http://en.wikipedia.org/wiki/Wikipedia:Article_Feedback_Tool/Version_5',
140141 'articlefeedbackv5-transparency-terms' => 'By posting, you agree to transparency under these $1.',
141142 'articlefeedbackv5-transparency-terms-linktext' => 'terms',
142 - 'articlefeedbackv5-transparency-terms-url' => 'Project:Privacy_policy', // TODO: Confirm correct link
 143+ 'articlefeedbackv5-transparency-terms-url' => 'http://wikimediafoundation.org/wiki/Feedback_privacy_statement',
143144 'articlefeedbackv5-section-linktext' => 'feedback',
144145 'articlefeedbackv5-titlebar-linktext' => 'Feedback',
145146 'articlefeedbackv5-toolbox-linktext' => 'Rate this page',
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
@@ -173,7 +173,9 @@
174174 <h3><html:msg key="help-tooltip-title" /></h3><span class="articleFeedbackv5-tooltip-close">X</span>\
175175 <div class="clear"></div>\
176176 <p><html:msg key="help-tooltip-info" /></p>\
177 - <p><a target="_blank" href="http://en.wikipedia.org/wiki/Wikipedia:Article_Feedback_Tool/Version_5"><html:msg key="help-tooltip-linktext" />&nbsp;&gt;&gt;</a></p>\
 177+ <p><a target="_blank" href="' +
 178+mw.msg( 'articlefeedbackv5-help-tooltip-linkurl' )
 179++ '"><html:msg key="help-tooltip-linktext" />&nbsp;&gt;&gt;</a></p>\
178180 </div>\
179181 <div class="tooltip-bottom"></div>\
180182 </div>\
@@ -290,7 +292,7 @@
291293 .html( $.articleFeedbackv5.buildLink(
292294 'articlefeedbackv5-transparency-terms',
293295 {
294 - href: mw.util.wikiGetlink( mw.config.get( 'wgArticleFeedbackv5TermsPage' ) ),
 296+ href: 'http://wikimediafoundation.org/wiki/Feedback_privacy_statement',
295297 text: 'articlefeedbackv5-transparency-terms-linktext',
296298 target: '_blank'
297299 } ) );
Index: trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.hooks.php
@@ -101,6 +101,7 @@
102102 'articlefeedbackv5-help-tooltip-title',
103103 'articlefeedbackv5-help-tooltip-info',
104104 'articlefeedbackv5-help-tooltip-linktext',
 105+ 'articlefeedbackv5-help-tooltip-linkurl',
105106 'articlefeedbackv5-transparency-terms',
106107 'articlefeedbackv5-transparency-terms-linktext',
107108 'parentheses',

Status & tagging log