r105005 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105004‎ | r105005 | r105006 >
Date:21:41, 2 December 2011
Author:seanheavey
Status:deferred
Tags:
Comment:
fixes for trac #14, #15
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-button.png (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-button.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css
@@ -183,44 +183,44 @@
184184 background-position: center center;
185185 cursor: pointer;
186186 }
187 -.articleFeedbackv5-rating-label {
 187+#mw-articlefeedbackv5 .articleFeedbackv5-rating-label {
188188 /* @embed */
189189 background-image: url(images/star-empty.png);
190190 }
191191
192 -.articleFeedbackv5-rating-clear {
 192+#mw-articlefeedbackv5 .articleFeedbackv5-rating-clear {
193193 /* @embed */
194194 background-image: url(images/trash.png);
195195 display: none;
196196 }
197197
198 -.articleFeedbackv5-rating-labels:hover .articleFeedbackv5-rating-clear {
 198+#mw-articlefeedbackv5 .articleFeedbackv5-rating-labels:hover .articleFeedbackv5-rating-clear {
199199 /* @embed */
200200 background-image: url(images/trash-hover.png);
201201 }
202202
203 -.articleFeedbackv5-rating-label.articleFeedbackv5-rating-label-full {
 203+#mw-articlefeedbackv5 .articleFeedbackv5-rating-label.articleFeedbackv5-rating-label-full {
204204 /* @embed */
205 - background-image: url(images/star-full.png);
 205+ background-image: url(images/star-full.png) !important;
206206 }
207207
208 -.articleFeedbackv5-expired .articleFeedbackv5-rating-label.articleFeedbackv5-rating-label-full {
 208+#mw-articlefeedbackv5 .articleFeedbackv5-expired .articleFeedbackv5-rating-label.articleFeedbackv5-rating-label-full {
209209 /* @embed */
210210 background-image: url(images/star-full-expired.png);
211211 }
212212
213 -.articleFeedbackv5-rating-new .articleFeedbackv5-rating-label.articleFeedbackv5-rating-label-full,
214 -.articleFeedbackv5-rating .articleFeedbackv5-rating-label.articleFeedbackv5-rating-label-hover-tail {
 213+#mw-articlefeedbackv5 .articleFeedbackv5-rating-new .articleFeedbackv5-rating-label.articleFeedbackv5-rating-label-full,
 214+#mw-articlefeedbackv5 .articleFeedbackv5-rating .articleFeedbackv5-rating-label.articleFeedbackv5-rating-label-hover-tail {
215215 /* @embed */
216216 background-image: url(images/star-new.png);
217217 }
218218
219 -.articleFeedbackv5-rating .articleFeedbackv5-rating-label.articleFeedbackv5-rating-label-hover-head {
 219+#mw-articlefeedbackv5 .articleFeedbackv5-rating .articleFeedbackv5-rating-label.articleFeedbackv5-rating-label-hover-head {
220220 /* @embed */
221221 background-image: url(images/star-new-hover.png);
222222 }
223223
224 -.articleFeedbackv5-rating-new .articleFeedbackv5-rating-label.articleFeedbackv5-rating-label-down {
 224+#mw-articlefeedbackv5 .articleFeedbackv5-rating-new .articleFeedbackv5-rating-label.articleFeedbackv5-rating-label-down {
225225 /* @embed */
226226 background-image: url(images/star-new-down.png);
227227 }
@@ -237,7 +237,7 @@
238238 .articleFeedbackv5-rating {
239239 float: left;
240240 width: 11em;
241 - height: 5em;
 241+ height: 35px;
242242 margin-bottom: 0.5em;
243243 }
244244
@@ -705,6 +705,9 @@
706706
707707
708708 /*** Dialog ***/
 709+body .ui-widget-overlay {
 710+ opacity: .45;
 711+}
709712 .articleFeedbackv5-dialog {
710713 border: 1px solid #cccccc;
711714 }
@@ -713,7 +716,6 @@
714717 background: #f5faff !important;
715718 border: none;
716719 }
717 -
718720 .articleFeedbackv5-dialog.ui-dialog .ui-dialog-content {
719721 background: #f5faff;
720722 }
@@ -732,4 +734,25 @@
733735 .articleFeedbackv5-dialog.ui-dialog .articleFeedbackv5-tooltip {
734736 right: -67px;
735737 }
736 -
 738+body .ui-dialog .ui-icon-closethick {
 739+ text-indent: -90000px;
 740+ width: 23px;
 741+ height: 22px;
 742+ background: url(images/bg-close-off.png) no-repeat !important;
 743+}
 744+body .ui-dialog .ui-icon-closethick:hover {
 745+ background: url(images/bg-close-hov.png) no-repeat !important;
 746+ border: none !important;
 747+}
 748+.ui-dialog .ui-dialog-titlebar-close {
 749+position: absolute;
 750+right: .75em;
 751+top: 50%;
 752+width: 19px;
 753+margin: -10px 0 0 0;
 754+padding: 0 !important;
 755+height: auto !important;
 756+}
 757+.ui-dialog .ui-dialog-titlebar-close.ui-state-hover {
 758+ border: none !important;
 759+}
\ No newline at end of file

Status & tagging log