r104998 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104997‎ | r104998 | r104999 >
Date:20:22, 2 December 2011
Author:seanheavey
Status:deferred
Tags:
Comment:
Fixed multiple minor styling issues and bugs
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-button-active.png (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-submit.png (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-button-active.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-submit.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css
@@ -511,8 +511,11 @@
512512
513513 .articleFeedbackv5-ui .buttons .articleFeedbackv5-button-placeholder {
514514 display: inline-block;
515 - height: 20px;
516 - width: 50px;
 515+ height: 19px;
 516+ line-height: 19px;
 517+ font-size: .9em;
 518+ min-width: 34px;
 519+ padding: 0 8px;
517520 text-align: center;
518521 color: #333;
519522 font-weight: bold;
@@ -529,7 +532,7 @@
530533 .articleFeedbackv5-ui .buttons .articleFeedbackv5-button-placeholder:hover {
531534 background: url(images/bg-button-hov.png) repeat-x;
532535 cursor: pointer;
533 - color: #fff;
 536+ color: #333;
534537 }
535538
536539 .articleFeedbackv5-ui .buttons .articleFeedbackv5-button-placeholder-active,
@@ -548,7 +551,7 @@
549552 padding: 10px;
550553 font-size: 1.0em;
551554 font: sans-serif;
552 - color: #ddd;
 555+ color: #999;
553556 }
554557
555558 .articleFeedbackv5-ui .feedback-text.active {
@@ -585,13 +588,14 @@
586589 }
587590
588591 .articleFeedbackv5-ui .articleFeedbackv5-submit span {
589 - font-size: 16px;
 592+ font-size: 14px;
 593+ font-weight: bold;
590594 display: inline-block;
591 - height: 21px;
 595+ height: 19px;
592596 text-align: center;
593597 color: #fff;
594 - text-shadow: 1px 1px 1px #000;
595 - padding: 0 30px 0 0;
 598+ /*text-shadow: 1px 1px 1px #000;*/
 599+ padding: 1px 30px 0 0;
596600 background: url(images/bg-submit-icon.png) right center no-repeat;
597601 }
598602
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
@@ -728,13 +728,15 @@
729729 <p class="instructions-left"><html:msg key="bucket3-rating-question" /></p>\
730730 <div class="articleFeedbackv5-rating articleFeedbackv5-rating-new">\
731731 <input type="hidden" name="rating" value="0">\
732 - <div class="articleFeedback-rating-labels articleFeedback-visibleWith-form">\
733 - <div class="articleFeedbackv5-rating-label" rel="1"></div>\
734 - <div class="articleFeedbackv5-rating-label" rel="2"></div>\
735 - <div class="articleFeedbackv5-rating-label" rel="3"></div>\
736 - <div class="articleFeedbackv5-rating-label" rel="4"></div>\
737 - <div class="articleFeedbackv5-rating-label" rel="5"></div>\
738 - <div class="articleFeedbackv5-rating-clear" original-title="Remove this rating" style="display: block; "></div>\
 732+ <div class="bucket3-rating">\
 733+ <div class="articleFeedback-rating-labels articleFeedback-visibleWith-form">\
 734+ <div class="articleFeedbackv5-rating-label" rel="1"></div>\
 735+ <div class="articleFeedbackv5-rating-label" rel="2"></div>\
 736+ <div class="articleFeedbackv5-rating-label" rel="3"></div>\
 737+ <div class="articleFeedbackv5-rating-label" rel="4"></div>\
 738+ <div class="articleFeedbackv5-rating-label" rel="5"></div>\
 739+ <div class="articleFeedbackv5-rating-clear" original-title="Remove this rating"></div>\
 740+ </div>\
739741 </div>\
740742 <div style="clear:both;"></div>\
741743 <div class="articleFeedbackv5-visibleWith-form">\

Status & tagging log