r104981 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104980‎ | r104981 | r104982 >
Date:17:59, 2 December 2011
Author:bsitu
Status:ok
Tags:
Comment:
followup to -r104757 - use Title::getPrefixedText() insetead of raw string concatenation to construct FeedbackDashboard title text
Modified paths:
  • /trunk/extensions/MoodBar/ApiFeedbackDashboardResponse.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MoodBar/ApiFeedbackDashboardResponse.php
@@ -3,7 +3,7 @@
44 class ApiFeedbackDashboardResponse extends ApiBase {
55
66 public function execute() {
7 - global $wgRequest, $wgUser, $wgContLang, $wgParser;
 7+ global $wgRequest, $wgUser, $wgParser;
88
99 if ( $wgUser->isAnon() ) {
1010 $this->dieUsage( "You don't have permission to do that", 'permission-denied' );
@@ -32,8 +32,9 @@
3333 if ( $commenter !== null && $commenter->isAnon() == false ) {
3434 $talkPage = $commenter->getTalkPage();
3535
36 - $feedback_link = wfMessage('moodbar-feedback-response-title')->params($wgContLang->getNsText( NS_SPECIAL ) .
37 - ':FeedbackDashboard/' . $item->getProperty('feedback'))->escaped();
 36+ $feedback_link = wfMessage('moodbar-feedback-response-title')->
 37+ params( SpecialPage::getTitleFor( 'FeedbackDashboard', $item->getProperty('feedback') )->
 38+ getPrefixedText() )->escaped();
3839
3940 $api = new ApiMain( new FauxRequest( array(
4041 'action' => 'edit',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r104757followup to r104644 - change for code reviewbsitu21:47, 30 November 2011

Status & tagging log