r104920 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104919‎ | r104920 | r104921 >
Date:23:35, 1 December 2011
Author:seanheavey
Status:deferred
Tags:
Comment:
additional graphics and some integration with Reha's latest code
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-button-active.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-button-disable.png (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-button-hov.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-close-hov.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-close-off.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-submit.png (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-close-off.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-close-off.png
___________________________________________________________________
Added: svn:mime-type
11 + application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-button-active.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-button-active.png
___________________________________________________________________
Added: svn:mime-type
22 + application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-submit.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-button-disable.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-close-hov.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-close-hov.png
___________________________________________________________________
Added: svn:mime-type
33 + application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-button-hov.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-button-hov.png
___________________________________________________________________
Added: svn:mime-type
44 + application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css
@@ -514,22 +514,28 @@
515515 height: 20px;
516516 width: 50px;
517517 text-align: center;
518 - color: #fff;
519 - text-shadow: 1px 1px 1px #000;
 518+ color: #333;
 519+ font-weight: bold;
520520 background: url(images/bg-button-disable.png) repeat-x;
521521 -moz-border-radius: 3px;
522522 -webkit-border-radius: 3px;
523523 border-radius: 3px; /* future proofing */
524524 -khtml-border-radius: 3px; /* for old Konqueror browsers */
 525+ -moz-box-shadow: -2px 2px 1px #999;
 526+ -webkit-box-shadow: -2px 2px 1px #999;
 527+ box-shadow: -2px 2px 1px #999;
525528 }
526529
527530 .articleFeedbackv5-ui .buttons .articleFeedbackv5-button-placeholder:hover {
528 - background: url(images/bg-button.png) repeat-x;
 531+ background: url(images/bg-button-hov.png) repeat-x;
529532 cursor: pointer;
 533+ color: #fff;
530534 }
531535
532 -.articleFeedbackv5-ui .buttons .articleFeedbackv5-button-placeholder-active {
 536+.articleFeedbackv5-ui .buttons .articleFeedbackv5-button-placeholder-active,
 537+.articleFeedbackv5-ui .buttons .articleFeedbackv5-button-placeholder-active:hover {
533538 background: url(images/bg-button.png) repeat-x;
 539+ color: #fff;
534540 }
535541
536542 .articleFeedbackv5-ui .feedback-text {
@@ -552,7 +558,7 @@
553559 .articleFeedbackv5-ui .articleFeedbackv5-disclosure {
554560 float: right;
555561 width: 335px;
556 - margin: 10px 0 0;
 562+ margin: 18px 0 0;
557563 }
558564
559565 .articleFeedbackv5-ui .articleFeedbackv5-disclosure p {
@@ -573,9 +579,9 @@
574580 -webkit-border-radius: 3px;
575581 border-radius: 3px; /* future proofing */
576582 -khtml-border-radius: 3px; /* for old Konqueror browsers */
577 - -moz-box-shadow: -3px 3px 3px #999;
578 - -webkit-box-shadow: -3px 3px 3px #999;
579 - box-shadow: -3px 3px 3px #999;
 583+ -moz-box-shadow: -2px 2px 1px #999;
 584+ -webkit-box-shadow: -2px 2px 1px #999;
 585+ box-shadow: -2px 2px 1px #999;
580586 }
581587
582588 .articleFeedbackv5-ui .articleFeedbackv5-submit span {
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
@@ -232,7 +232,7 @@
233233 <textarea id="find-feedback" class="feedback-text" name="comment"></textarea>\
234234 </div>\
235235 <div class="articleFeedbackv5-disclosure">\
236 - <p class="articlefeedbackv5-shared-on-feedback"></p>\
 236+ <!-- <p class="articlefeedbackv5-shared-on-feedback"></p> -->\
237237 <p class="articlefeedbackv5-transparency-terms"></p>\
238238 </div>\
239239 <button class="articleFeedbackv5-submit" type="submit" disabled="disabled"><html:msg key="bucket1-form-submit" /></button>\
@@ -461,7 +461,7 @@
462462 <textarea id="find-feedback" class="feedback-text" name="comment"></textarea>\
463463 </div>\
464464 <div class="articleFeedbackv5-disclosure">\
465 - <p class="articlefeedbackv5-shared-on-feedback"></p>\
 465+ <!-- <p class="articlefeedbackv5-shared-on-feedback"></p> -->\
466466 <p class="articlefeedbackv5-transparency-terms"></p>\
467467 </div>\
468468 <button class="articleFeedbackv5-submit" type="submit" disabled="disabled">\
@@ -753,7 +753,7 @@
754754 <textarea id="find-feedback" class="feedback-text" name="comment"></textarea>\
755755 </div>\
756756 <div class="articleFeedbackv5-disclosure">\
757 - <p class="articlefeedbackv5-shared-on-feedback"></p>\
 757+ <!-- <p class="articlefeedbackv5-shared-on-feedback"></p> -->\
758758 <p class="articlefeedbackv5-transparency-terms"></p>\
759759 </div>\
760760 <button class="articleFeedbackv5-submit" type="submit" disabled="disabled"><html:msg key="bucket3-form-submit" /></button>\

Status & tagging log