r104849 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104848‎ | r104849 | r104850 >
Date:13:06, 1 December 2011
Author:hashar
Status:ok
Tags:
Comment:
MFT to 1.18wmf1 vipsTest issues

r104733 r104735
- compare on load not on ready
- pass env under windows (fixed by r104735)
Modified paths:
  • /branches/wmf/1.18wmf1/extensions/VipsScaler (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/VipsScaler/VipsScaler_body.php (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/VipsScaler/modules/ext.vipsScaler/ext.vipsScaler.js (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/VipsScaler/modules/ext.vipsScaler/ext.vipsScaler.js
@@ -1,4 +1,5 @@
2 -jQuery( function( $ ) {
 2+jQuery( window ).load( ( function( $ ) {
 3+ return function( event ) {
34 $.vipsScaler = {
45 /** function to alternate between both thumbnails */
56 switchThumbs: function() {
@@ -51,5 +52,6 @@
5253 function() { $.vipsScaler.switchThumbs(); }
5354 );
5455 }
55 -}
 56+};
 57+} )( jQuery )
5658 );
Index: branches/wmf/1.18wmf1/extensions/VipsScaler/VipsScaler_body.php
@@ -400,9 +400,8 @@
401401 */
402402 public function execute() {
403403 # Build and escape the command string
404 - $cmd =
405 - 'IM_CONCURRENCY=1 ' .
406 - wfEscapeShellArg(
 404+ $env = array( 'IM_CONCURRENCY' => '1' );
 405+ $cmd = wfEscapeShellArg(
407406 $this->vips,
408407 array_shift( $this->args ),
409408 $this->input, $this->output
@@ -416,7 +415,7 @@
417416
418417 # Execute
419418 $retval = 0;
420 - $this->err = wfShellExec( $cmd, $retval );
 419+ $this->err = wfShellExec( $cmd, $retval, $env );
421420
422421 # Cleanup temp file
423422 if ( $this->removeInput ) {
Property changes on: branches/wmf/1.18wmf1/extensions/VipsScaler
___________________________________________________________________
Modified: svn:mergeinfo
424423 Merged /trunk/extensions/VipsScaler:r104733,104735

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r104733Fix VipsScaler for Windows which does not support passing environment variabl...btongminh20:11, 30 November 2011
r104735Follow-up r104733, fix stupid missing $btongminh20:22, 30 November 2011

Status & tagging log