r104841 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r104840‎ | r104841 | r104842 >
Date:06:56, 1 December 2011
Author:santhosh
Status:ok (Comments)
Tags:
Comment:
bho is the correct ISO 639 code for Bhojpuri. But Bhojpuri wikipedia is bh.wikipedia.org.
So duplicating bh mapping to bho too.
Follow up r104837
Modified paths:
  • /trunk/extensions/WebFonts/resources/ext.webfonts.fontlist.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WebFonts/resources/ext.webfonts.fontlist.js
——@@ -373,7 +373,8 @@
374374 // en: [ "RufScript", "Perizia", "Ubuntu" ],
375375 am: [ "AbyssinicaSIL" ],
376376 as: [ "Lohit Assamese" ],
377 - bh: [ "Lohit Devanagari" ],
 377+ bh: [ "Lohit Devanagari" ],
 378+ bho: [ "Lohit Devanagari" ],
378379 bn: [ "Lohit Bengali" ],
379380 bpy: [ "Lohit Bengali" ],
380381 cdo: [ "Charis SIL" ],

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r104837Add support for Nepali, Konkani and Bhojpurisanthosh05:26, 1 December 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   22:04, 1 December 2011

Note that per en:List_of_ISO_639-1_codes bh is a macro code for en:Bihari languages, of which Bhojpuri is one. There's not currently a separate bho.wikipedia.org, and both are labeled in our language lists as 'भोजपुरी' ('Bhojpuri') though a comment in Names.php does note that bh should be a macro.

Sounds like it probably makes sense to give them the same font config.

#Comment by Nikerabbit (talk | contribs)   09:08, 2 December 2011

I'm still confused about this. Are we using the correct language codes everywhere? If not there should be a bug for that.

#Comment by Brion VIBBER (talk | contribs)   19:51, 2 December 2011

It's correct-ish in that bh is a superset of bho. But possibly that's one y'all would prefer to fix at some point.

Status & tagging log