r104823 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104822‎ | r104823 | r104824 >
Date:01:24, 1 December 2011
Author:yaron
Status:deferred
Tags:
Comment:
Partial fix for r102365 - $aggregating_property needs to be checked for both blank and null
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_TemplateField.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_TemplateField.php
@@ -264,7 +264,7 @@
265265
266266 // Add a row with an inline query to this table, for
267267 // aggregation, if a property was specified.
268 - if ( $aggregating_property !== '' ) {
 268+ if ( !is_null( $aggregating_property ) && $aggregating_property !== '' ) {
269269 if ( count( $template_fields ) > 0 ) {
270270 $tableText .= "|-\n";
271271 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102365strict comparators for empty stringsjeroendedauw02:25, 8 November 2011