r104784 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104783‎ | r104784 | r104785 >
Date:23:29, 30 November 2011
Author:tparscal
Status:deferred
Tags:
Comment:
Fixed image links and switched to using inline block for toolbar
Modified paths:
  • /trunk/extensions/VisualEditor/VisualEditor.php (modified) (history)
  • /trunk/extensions/VisualEditor/demo/index.html (modified) (history)
  • /trunk/extensions/VisualEditor/modules/es/styles/es.ToolbarView.css (modified) (history)

Diff [purge]

Index: trunk/extensions/VisualEditor/VisualEditor.php
@@ -109,6 +109,7 @@
110110 'es/styles/es.ContextView.css',
111111 'es/styles/es.ContentView.css',
112112 'es/styles/es.DocumentView.css',
 113+ 'es/styles/es.ToolbarView.css',
113114 ),
114115 'dependencies' => array(
115116 'jquery',
Index: trunk/extensions/VisualEditor/demo/index.html
@@ -7,6 +7,7 @@
88 <link rel="stylesheet" href="../modules/es/styles/es.ContextView.css">
99 <link rel="stylesheet" href="../modules/es/styles/es.ContentView.css">
1010 <link rel="stylesheet" href="../modules/es/styles/es.DocumentView.css">
 11+ <link rel="stylesheet" href="../modules/es/styles/es.ToolbarView.css">
1112 <link rel="stylesheet" href="../modules/sandbox/sandbox.css">
1213 <style>
1314 body {
Index: trunk/extensions/VisualEditor/modules/es/styles/es.ToolbarView.css
@@ -1,35 +1,25 @@
2 -.es-toolbarGroups:after,
3 -.es-toolbarGroup:after {
4 - content: ".";
5 - display: block;
6 - height: 0;
7 - clear: both;
8 - visibility: hidden;
9 -}
102 .es-toolbarGroup {
11 - float: left;
 3+ display: inline-block;
124 padding: 0.25em;
135 }
14 -.es-toolbarGroup-preview {
15 - float: right;
16 -}
176 .es-toolbarDivider {
18 - float: left;
 7+ display: inline-block;
198 width: 1px;
209 height: 24px;
2110 margin: 0.5em 0 0.5em 0.5em;
2211 background-color: #dddddd;
2312 }
2413 .es-toolbarLabel {
25 - float: left;
 14+ display: inline-block;
2615 padding: 0.5em 0.75em;
2716 line-height: 22px;
2817 font-size: 0.8em;
2918 color: #555555;
 19+ vertical-align: top;
3020 }
3121 .es-toolbarButtonTool,
3222 .es-toolbarDropdownTool {
33 - float: left;
 23+ display: inline-block;
3424 padding: 0.25em;
3525 border: solid 1px transparent;
3626 border-radius: 0.125em;
@@ -44,6 +34,7 @@
4535 }
4636 .es-toolbarButtonTool:before {
4737 content: " ";
 38+ position: absolute;
4839 display: block;
4940 height: 22px;
5041 width: 22px;
@@ -55,18 +46,18 @@
5647 .es-toolbarButtonTool:active,
5748 .es-toolbarButtonTool-down {
5849 border-color: #dddddd;
59 - background-image: url(images/fade-down.png);
 50+ background-image: url(../images/fade-down.png);
6051 background-position: top left;
6152 background-repeat: repeat-x;
6253 }
6354 .es-toolbarButtonTool-bold:before {
64 - background-image: url(../es/images/bold.png);
 55+ background-image: url(../images/bold.png);
6556 }
6657 .es-toolbarButtonTool-italic:before {
67 - background-image: url(../es/images/italic.png);
 58+ background-image: url(../images/italic.png);
6859 }
6960 .es-toolbarButtonTool-clear:before {
70 - background-image: url(../es/images/clear.png);
 61+ background-image: url(../images/clear.png);
7162 }
7263 .es-toolbarDropdownTool {
7364 }

Status & tagging log