r104777 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104776‎ | r104777 | r104778 >
Date:23:11, 30 November 2011
Author:catrope
Status:ok
Tags:
Comment:
1.18wmf1: Merge MoodBar to trunk state again to pick up r104775
Modified paths:
  • /branches/wmf/1.18wmf1/extensions/MoodBar/MoodBar.i18n.php (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/MoodBar/MoodBar.php (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/MoodBar/modules/ext.moodBar.dashboard/ext.moodBar.dashboard.js (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/MoodBar/MoodBar.i18n.php
@@ -142,8 +142,6 @@
143143 'response-ajax-success-body' => 'Your response has been added.',
144144 'response-ajax-error-head' => 'Oops!',
145145 'response-ajax-error-body' => 'There was an error adding your response. <br />Please try again later.',
146 -
147 -
148146 );
149147
150148 /** Message documentation (Message documentation)
Index: branches/wmf/1.18wmf1/extensions/MoodBar/modules/ext.moodBar.dashboard/ext.moodBar.dashboard.js
@@ -504,7 +504,7 @@
505505 * Require at least 1 character and limit to 5000
506506 */
507507 function validateResponse($item) {
508 - var response = $item.find('.fbd-response-text').val();
 508+ var response = $.trim( $item.find('.fbd-response-text').val() );
509509 if( response.length > 0 && response.length <= 5000 ) {
510510 $item.find( '.fbd-response-submit, .fbd-response-preview').removeAttr('disabled');
511511 } else {
Index: branches/wmf/1.18wmf1/extensions/MoodBar/MoodBar.php
@@ -208,9 +208,9 @@
209209 array(
210210 'buckets' =>
211211 array(
212 - 'feedback' => 80,
213 - 'share' => 10,
214 - 'editing' => 10,
 212+ 'feedback' => 100,
 213+ 'share' => 0, //disabled
 214+ 'editing' => 0, //disabled
215215 ),
216216 'version' => 3,
217217 'expires' => 30,

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r104775trimmed feedback responses, and changed bucket config to remove a/b testingrmoen23:07, 30 November 2011

Status & tagging log