r104772 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104771‎ | r104772 | r104773 >
Date:23:04, 30 November 2011
Author:seanheavey
Status:deferred
Tags:
Comment:
start of revisions from Fabrice.
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-submit-icon.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-submit.png (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-submit.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-submit-icon.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-submit-icon.png
___________________________________________________________________
Added: svn:mime-type
11 + application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css
@@ -523,7 +523,7 @@
524524 color: #000;
525525 }
526526 .articleFeedbackv5-panel .articleFeedbackv5-disclosure {
527 - float: left;
 527+ float: right;
528528 width: 335px;
529529 margin: 10px 0 0;
530530 }
@@ -532,10 +532,11 @@
533533 font-size: 0.75em;
534534 }
535535 .articleFeedbackv5-panel .articleFeedbackv5-submit {
536 - float: right;
537 - height: 25px;
538 - width: 180px;
 536+ float: left;
 537+ height: 30px;
 538+ width: auto;
539539 text-align: center;
 540+ padding: 0 6px;
540541 background: url(images/bg-submit-disable.png) repeat-x !important;
541542 margin: 10px 30px 0 0 !important;
542543 border: none !important;
@@ -543,15 +544,24 @@
544545 -webkit-border-radius: 3px;
545546 border-radius: 3px; /* future proofing */
546547 -khtml-border-radius: 3px; /* for old Konqueror browsers */
 548+ -moz-box-shadow: -3px 3px 3px #999;
 549+ -webkit-box-shadow: -3px 3px 3px #999;
 550+ box-shadow: -3px 3px 3px #999;
547551 }
548552 .articleFeedbackv5-panel .articleFeedbackv5-submit span {
549553 font-size: 16px;
550 - line-height: 15px;
 554+ display: inline-block;
 555+ height: 21px;
551556 text-align: center;
552557 color: #fff;
553558 text-shadow: 1px 1px 1px #000;
 559+ padding: 0 30px 0 0;
 560+ background: url(images/bg-submit-icon.png) right center no-repeat;
554561 }
555562 /*** Option 2 ***/
 563+.articleFeedbackv5-tags ul {
 564+ margin: 0 0 10px;
 565+}
556566 .articleFeedbackv5-tags ul li {
557567 color: #666;
558568 list-style: none;
@@ -592,6 +602,9 @@
593603 .articleFeedbackv5-tags ul li label {
594604 padding: 0 0 0 22px;
595605 cursor: pointer;
 606+ display: inline-block;
 607+ height: 16px;
 608+ line-height: 18px;
596609 }
597610 .articleFeedbackv5-tags ul li .articleFeedbackv5-bucket2-suggestion-label {
598611 background: url(images/bg-tag-suggestion-off.png) no-repeat 0 center;

Status & tagging log