r104761 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104760‎ | r104761 | r104762 >
Date:22:06, 30 November 2011
Author:tparscal
Status:deferred
Tags:
Comment:
Removed soft undo stuff
Modified paths:
  • /trunk/extensions/VisualEditor/modules/es/models/es.SurfaceModel.js (modified) (history)
  • /trunk/extensions/VisualEditor/modules/es/views/es.SurfaceView.js (modified) (history)

Diff [purge]

Index: trunk/extensions/VisualEditor/modules/es/models/es.SurfaceModel.js
@@ -115,9 +115,8 @@
116116 *
117117 * @method
118118 * @param {Integer} steps Number of steps to reverse
119 - * @param {Boolean} soft Whether to consider selection states as steps
120119 */
121 -es.SurfaceModel.prototype.undo = function( steps, soft ) {
 120+es.SurfaceModel.prototype.undo = function( steps ) {
122121 // TODO: Implement me!
123122 this.emit( 'undo'/*, transaction/selection*/ );
124123 };
@@ -127,9 +126,8 @@
128127 *
129128 * @method
130129 * @param {Integer} steps Number of steps to repeat
131 - * @param {Boolean} soft Whether to consider selection states as steps
132130 */
133 -es.SurfaceModel.prototype.redo = function( steps, soft ) {
 131+es.SurfaceModel.prototype.redo = function( steps ) {
134132 // TODO: Implement me!
135133 this.emit( 'redo'/*, transaction/selection*/ );
136134 };
Index: trunk/extensions/VisualEditor/modules/es/views/es.SurfaceView.js
@@ -401,18 +401,6 @@
402402 this.handleEnter();
403403 e.preventDefault();
404404 break;
405 - // U (soft undo/soft redo)
406 - case 85:
407 - if ( e.metaKey || e.ctrlKey ) {
408 - if ( this.keyboard.keys.shift ) {
409 - this.model.redo( 1, true );
410 - } else {
411 - this.model.undo( 1, true );
412 - }
413 - return false;
414 - }
415 - handleInsert();
416 - break;
417405 // Z (undo/redo)
418406 case 90:
419407 if ( e.metaKey || e.ctrlKey ) {

Status & tagging log