r104756 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104755‎ | r104756 | r104757 >
Date:21:45, 30 November 2011
Author:preilly
Status:ok
Tags:
Comment:
remove unneeded variables
Modified paths:
  • /trunk/extensions/MobileFrontend/MobileFrontend.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/MobileFrontend.php
@@ -68,8 +68,9 @@
6969 $wgHooks['TestCanonicalRedirect'][] = array( &$wgExtMobileFrontend, 'testCanonicalRedirect' );
7070
7171 /**
72 - * Make the classes stripped from page content configurable. Each item will
73 - * be stripped from the page. See $itemsToRemove for more info
 72+ * Make the classes, tags and ids stripped from page content configurable.
 73+ * Each item will be stripped from the page.
 74+ * See $itemsToRemove for more information.
7475 */
7576 $wgMFRemovableClasses = array();
7677
@@ -87,7 +88,7 @@
8889 }
8990
9091 class ExtMobileFrontend {
91 - const VERSION = '0.5.85';
 92+ const VERSION = '0.5.86';
9293
9394 /**
9495 * @var DOMDocument
@@ -1075,9 +1076,6 @@
10761077 */
10771078 public function renderLogin() {
10781079 wfProfileIn( __METHOD__ );
1079 - $username = self::$messages['mobile-frontend-username'];
1080 - $password = self::$messages['mobile-frontend-password'];
1081 - $login = self::$messages['mobile-frontend-login'];
10821080 $form = Html::openElement( 'form',
10831081 array( 'name' => 'userlogin',
10841082 'method' => 'post',
@@ -1089,7 +1087,7 @@
10901088 Html::openElement( 'td',
10911089 array( 'class' => 'mw-label' ) ) .
10921090 Html::element( 'label',
1093 - array( 'for' => 'wpName1' ), $username ) .
 1091+ array( 'for' => 'wpName1' ), self::$messages['mobile-frontend-username'] ) .
10941092 Html::closeElement( 'td' ) .
10951093 Html::closeElement( 'tr' ) .
10961094 Html::openElement( 'tr' ) .
@@ -1106,7 +1104,7 @@
11071105 Html::openElement( 'td',
11081106 array( 'class' => 'mw-label' ) ) .
11091107 Html::element( 'label',
1110 - array( 'for' => 'wpPassword1' ), $password ) .
 1108+ array( 'for' => 'wpPassword1' ), self::$messages['mobile-frontend-password'] ) .
11111109 Html::closeElement( 'td' ) .
11121110 Html::closeElement( 'tr' ) .
11131111 Html::openElement( 'tr' ) .
@@ -1125,7 +1123,7 @@
11261124 Html::openElement( 'tr' ) .
11271125 Html::openElement( 'td',
11281126 array( 'class' => 'mw-submit' ) ) .
1129 - Html::input( 'wpLoginAttempt', $login, 'submit',
 1127+ Html::input( 'wpLoginAttempt', self::$messages['mobile-frontend-login'], 'submit',
11301128 array( 'id' => 'wpLoginAttempt',
11311129 'tabindex' => '3') ) .
11321130 Html::closeElement( 'td' ) .

Status & tagging log