r104749 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104748‎ | r104749 | r104750 >
Date:21:06, 30 November 2011
Author:jeroendedauw
Status:ok
Tags:
Comment:
js fixes
Modified paths:
  • /trunk/extensions/SemanticImageInput/RELEASE-NOTES (modified) (history)
  • /trunk/extensions/SemanticImageInput/SemanticImageInput.php (modified) (history)
  • /trunk/extensions/SemanticImageInput/resources/jquery.instantImage.js (modified) (history)
  • /trunk/extensions/SemanticImageInput/resources/sii.instantImage.js (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticImageInput/RELEASE-NOTES
@@ -3,8 +3,14 @@
44 Extension page on mediawiki.org: https://www.mediawiki.org/wiki/Extension:Semantic_Image_Input
55 Latest version of the release notes: http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/SemanticImageInput/RELEASE-NOTES?view=co
66
 7+
 8+=== Version 0.2 ===
 9+201x-xx-xx
 10+
 11+* Fixed some Internet Explorer specific JavaScript issues.
 12+
713 === Version 0.1 ===
8 -2011-11-xx
 14+2011-11-10
915
1016 Initial release with these features:
1117
Index: trunk/extensions/SemanticImageInput/resources/sii.instantImage.js
@@ -3,6 +3,7 @@
44 *
55 * TODO: this was written in a sprint; could be made less evil.
66 *
 7+ * @licence GNU GPL v3+
78 * @author Jeroen De Dauw <jeroendedauw at gmail dot com>
89 */
910
Index: trunk/extensions/SemanticImageInput/resources/jquery.instantImage.js
@@ -3,6 +3,7 @@
44 *
55 * TODO: this was written in a sprint; could be made less evil.
66 *
 7+ * @licence GNU GPL v3+
78 * @author Jeroen De Dauw <jeroendedauw at gmail dot com>
89 */
910
@@ -31,7 +32,7 @@
3233 'action': 'query',
3334 'format': 'json',
3435 'titles': this.options.imagename,
35 - 'redirects': 1,
 36+ 'redirects': 1
3637 },
3738 function( data ) {
3839 if ( data.query && data.query.redirects ) {
@@ -192,7 +193,7 @@
193194 _this.getRaw( _this.dispReqResult );
194195 } );
195196 }
196 - }
 197+ };
197198
198199 this.init = function() {
199200 $.extend( this.options, opts );
Index: trunk/extensions/SemanticImageInput/SemanticImageInput.php
@@ -34,7 +34,7 @@
3535 die( '<b>Error:</b> You need to have <a href="https://www.mediawiki.org/wiki/Extension:Semantic_Forms">Semantic Forms</a> installed in order to use Semantic Image Input.<br />' );
3636 }
3737
38 -define( 'SII_VERSION', '0.1' );
 38+define( 'SII_VERSION', '0.2 alpha' );
3939
4040 $wgExtensionCredits['semantic'][] = array(
4141 'path' => __FILE__,

Status & tagging log