r104747 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104746‎ | r104747 | r104748 >
Date:21:02, 30 November 2011
Author:rmoen
Status:ok
Tags:
Comment:
Follow up to r104642, removed protocol from terms url in language file
Modified paths:
  • /trunk/extensions/MoodBar/MoodBar.i18n.php (modified) (history)
  • /trunk/extensions/MoodBar/modules/ext.moodBar.dashboard/ext.moodBar.dashboard.css (modified) (history)

Diff [purge]

Index: trunk/extensions/MoodBar/MoodBar.i18n.php
@@ -133,7 +133,7 @@
134134 //Feedback Response
135135 'moodbar-response-terms' => 'By submitting, you agree to transparency under these $1.',
136136 'moodbar-response-link' => 'terms',
137 - 'moodbar-response-url' => 'http://wikimediafoundation.org/wiki/Feedback_privacy_statement',
 137+ 'moodbar-response-url' => '//wikimediafoundation.org/wiki/Feedback_privacy_statement',
138138 'response-back-text' => 'Back',
139139 'response-preview-text' => 'Preview',
140140 'response-ajax-action-head' => 'Responding...',
Index: trunk/extensions/MoodBar/modules/ext.moodBar.dashboard/ext.moodBar.dashboard.css
@@ -219,19 +219,16 @@
220220 padding:1.5em 2em;
221221 }
222222
223 -.fbd-ajax-response div {
224 -}
225 -
226223 .fbd-item-response-icon {
227 - float:left;
228 - display:block;
229 - height:56px;
230 - width:56px;
231 - background-position: center center;
232 - background-repeat: no-repeat;
233 - padding:8px 16px;
234 - position: relative;
235 - top: -16px;
 224+ float: left;
 225+ display: block;
 226+ height: 56px;
 227+ width: 56px;
 228+ background-position: center center;
 229+ background-repeat: no-repeat;
 230+ padding: 8px 16px;
 231+ position: relative;
 232+ top: -16px;
236233 }
237234
238235 .fbd-item-response > p {
@@ -240,11 +237,12 @@
241238 }
242239
243240 .fbd-item-response-success {
 241+ /* @embed */
244242 background-image: url(images/response-success.png);
245 -
246243 }
247244
248245 .fbd-item-response-error {
 246+ /* @embed */
249247 background-image: url(images/response-error.png);
250248 }
251249

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r104642added preview mode for responses, allow wikitext, add response icons / langua...rmoen01:37, 30 November 2011

Status & tagging log