r104730 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104729‎ | r104730 | r104731 >
Date:19:55, 30 November 2011
Author:tparscal
Status:deferred
Tags:
Comment:
Fixed context menu position when scrollTop is non-zero
Modified paths:
  • /trunk/extensions/VisualEditor/modules/es/views/es.ContextView.js (modified) (history)

Diff [purge]

Index: trunk/extensions/VisualEditor/modules/es/views/es.ContextView.js
@@ -66,7 +66,7 @@
6767 } else {
6868 this.$.addClass( 'es-contextView-position-right' );
6969 }
70 - if ( position.top + this.$menu.height() < $( window ).height() ) {
 70+ if ( position.top + this.$menu.height() < $( window ).height() + $( window ).scrollTop() ) {
7171 this.$.addClass( 'es-contextView-position-below' );
7272 } else {
7373 this.$.addClass( 'es-contextView-position-above' );

Status & tagging log