r104714 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104713‎ | r104714 | r104715 >
Date:18:48, 30 November 2011
Author:preilly
Status:ok
Tags:
Comment:
full screen fix for search
Modified paths:
  • /trunk/extensions/MobileFrontend/javascripts/beta_opensearch.js (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/beta_common.css (modified) (history)
  • /trunk/extensions/MobileFrontend/views/layout/_search_webkit.html.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/javascripts/beta_opensearch.js
@@ -48,7 +48,7 @@
4949 results.style.left = 0 + pixels;
5050 results.style.top = ( sq.offsetTop + sq.offsetHeight ) + pixels;
5151 results.style.width = document.body.clientWidth + pixels;
52 - results.style.height = '100%';
 52+ results.style.minHeight = '100%';
5353 results.style.borderTop = 'solid 1px #A6A6A6';
5454 results.style.backgroundColor = '#E6E6E6';
5555 results.style.paddingTop = 5 + pixels;
Index: trunk/extensions/MobileFrontend/stylesheets/beta_common.css
@@ -1,3 +1,13 @@
 2+html {
 3+ min-height: 100%;
 4+}
 5+
 6+body {
 7+ margin: 0px;
 8+ padding: 0px;
 9+ min-height: 100%;
 10+}
 11+
212 .clearlink {
313 background: url(images/close-button.png) no-repeat scroll 0 0 transparent;
414 background-position: center center;
Index: trunk/extensions/MobileFrontend/views/layout/_search_webkit.html.php
@@ -21,6 +21,7 @@
2222 $logoOnClick = ( self::$device['supports_javascript'] ) ? 'onclick="javascript:logoClick();"' : '';
2323
2424 $searchWebkitHtml = <<<EOD
 25+ {$openSearchResults}
2526 <div id='header'>
2627 <div id='searchbox' {$logoDisplayNone}>
2728 <img width="35" height="22" alt='Logo' id='logo' src='{$wgMobileFrontendLogo}' {$logoOnClick} {$logoDisplayNone} />
@@ -32,7 +33,6 @@
3334 </div>
3435 <button id='goButton' type='submit'></button>
3536 </form>
36 - {$openSearchResults}
3737 </div>
3838 <div class='nav' id='nav' {$logoDisplayNone}>
3939 {$languageSelectionDiv}

Status & tagging log